Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChartJS: Upgrade to V3 #6812

Closed
christophs78 opened this issue Jan 13, 2021 · 4 comments · Fixed by #7146
Closed

ChartJS: Upgrade to V3 #6812

christophs78 opened this issue Jan 13, 2021 · 4 comments · Fixed by #7146
Assignees
@christophs78
Labels
new feature
Milestone
11.0.0

Comments

@christophs78
Copy link
Contributor

Something we should keep in mind for PrimeFaces 11.
They are currently at https://github.com/chartjs/Chart.js/releases/tag/v3.0.0-beta.8.

https://www.chartjs.org/docs/master/getting-started/v3-migration
@tandraschko tandraschko added this to the 11.0 milestone Jan 13, 2021
@christophs78
Copy link
Contributor Author

As ChartJS 3 is gone into RC-state i´ll start to work on this.

christophs78 added a commit to christophs78/primefaces that referenced this issue Mar 19, 2021
@christophs78
primefaces#6812 ChartJS: Upgrade to V3
a2c5e8c
christophs78 added a commit to christophs78/primefaces that referenced this issue Mar 19, 2021
@christophs78
primefaces#6812 fix horizontal bar chart
12bb010
christophs78 added a commit to christophs78/primefaces that referenced this issue Mar 20, 2021
@christophs78
primefaces#6812 scales
13cd358
christophs78 added a commit to christophs78/primefaces that referenced this issue Mar 20, 2021
@christophs78
primefaces#6812 startAngle, tooltip
cad4c7c
christophs78 added a commit to christophs78/primefaces that referenced this issue Mar 20, 2021
@christophs78
primefaces#6812 title
46724f2
christophs78 added a commit to christophs78/primefaces that referenced this issue Mar 20, 2021
@christophs78
primefaces#6812 3rd party libs
a52ead5
christophs78 added a commit to christophs78/primefaces that referenced this issue Mar 21, 2021
@christophs78
primefaces#6812 axes
55e0a30
christophs78 added a commit to christophs78/primefaces that referenced this issue Mar 21, 2021
@christophs78
primefaces#6812 itemSelect
fd3d101
christophs78 added a commit to christophs78/primefaces that referenced this issue Mar 21, 2021
@christophs78
primefaces#6812 RC2
c313c74
@melloware melloware linked a pull request Mar 26, 2021 that will close this issue
#6812 ChartJS: Upgrade to V3 #7146
Merged
christophs78 added a commit to christophs78/primefaces that referenced this issue Mar 27, 2021
@christophs78
primefaces#6812 Chart.js v3.0.0-rc.2 --> Chart.js v3.0.0-rc.5
a98aeb9
christophs78 added a commit to christophs78/primefaces that referenced this issue Apr 3, 2021
@christophs78
primefaces#6812 Chart.js v3.0.0-rc.2 --> Chart.js v3.0.1
7d3e133
christophs78 added a commit to christophs78/primefaces that referenced this issue Apr 3, 2021
@christophs78
primefaces#6812 LineChart - fill
81f93f8
christophs78 added a commit to christophs78/primefaces that referenced this issue Apr 3, 2021
@christophs78
primefaces#6812 LineChart & RadarChart - tension
df4ed9a
christophs78 added a commit to christophs78/primefaces that referenced this issue Apr 3, 2021
@christophs78
primefaces#6812 JavaDoc
0acf465
christophs78 added a commit to christophs78/primefaces that referenced this issue Apr 3, 2021
@christophs78
primefaces#6812 JavaDoc
07afb72
christophs78 added a commit to christophs78/primefaces that referenced this issue Apr 16, 2021
@christophs78
primefaces#6812 Chart.js v3.0.1 --> Chart.js v3.1.0
4613a83
christophs78 added a commit to christophs78/primefaces that referenced this issue Apr 18, 2021
@christophs78
primefaces#6812 Chart.js v3.1.0 --> Chart.js v3.1.1 and some docu-upd…
1ec8acc 
…ates
christophs78 added a commit to christophs78/primefaces that referenced this issue Apr 18, 2021
@christophs78
primefaces#6812 docu; extender-example
3f20b27
christophs78 added a commit to christophs78/primefaces that referenced this issue Apr 18, 2021
@christophs78
primefaces#6812 migration-guide; reference
147d918
christophs78 added a commit to christophs78/primefaces that referenced this issue Apr 18, 2021
@christophs78
primefaces#6812 migration-guide; setLineTension --> setTension
713a65a
christophs78 added a commit to christophs78/primefaces that referenced this issue Apr 18, 2021
@christophs78
primefaces#6812 migration-guide; two blanks instead of <br/>
201eef3
christophs78 added a commit to christophs78/primefaces that referenced this issue Apr 18, 2021
@christophs78
primefaces#6812 migration-guide; PF API-changes
cfeaed3
christophs78 added a commit to christophs78/primefaces that referenced this issue Apr 19, 2021
@christophs78
primefaces#6812 cleanup and minor refactoring
599d8e8
christophs78 added a commit to christophs78/primefaces that referenced this issue Apr 19, 2021
@christophs78
primefaces#6812 migration-guide; fix startAngle
d70c2bf
christophs78 added a commit to christophs78/primefaces that referenced this issue May 14, 2021
@christophs78
primefaces#6812 Chart.js v3.1.1 --> Chart.js v3.2.1
3c5c48c
christophs78 added a commit to christophs78/primefaces that referenced this issue May 14, 2021
@christophs78
primefaces#6812 Chart.js v3.1.1 --> Chart.js v3.2.1 (migration guide)
f6454d8
melloware added a commit that referenced this issue May 14, 2021
@christophs78 @melloware
#6812 ChartJS: Upgrade to V3 (#7146)
06fa539 
* #6812 ChartJS: Upgrade to V3

* #6812 fix horizontal bar chart

* #6812 scales

* #6812 startAngle, tooltip

* #6812 title

* #6812 3rd party libs

* #6812 axes

* #6812 itemSelect

* #6812 RC2

* #6812 Chart.js v3.0.0-rc.2 --> Chart.js v3.0.0-rc.5

* #6812 Chart.js v3.0.0-rc.2 --> Chart.js v3.0.1

* #6812 LineChart - fill

* #6812 LineChart & RadarChart - tension

* #6812 JavaDoc

* #6812 JavaDoc

* #6812 Chart.js v3.0.1 --> Chart.js v3.1.0

* #6812 Chart.js v3.1.0 --> Chart.js v3.1.1 and some docu-updates

* #6812 docu; extender-example

* #6812 migration-guide; reference

* #6812 migration-guide; setLineTension --> setTension

* #6812 migration-guide; two blanks instead of <br/>

* #6812 migration-guide; PF API-changes

* #6812 cleanup and minor refactoring

* #6812 migration-guide; fix startAngle

* #6812 Chart.js v3.1.1 --> Chart.js v3.2.1

* #6812 Chart.js v3.1.1 --> Chart.js v3.2.1 (migration guide)

Co-authored-by: Melloware <mellowaredev@gmail.com>
christophs78 added a commit to christophs78/primefaces that referenced this issue Aug 14, 2021
@christophs78
primefaces#6812 ChartJs 3.2.1 --> 3.5.0
7495685
tandraschko pushed a commit that referenced this issue Aug 16, 2021
@christophs78
#6812 ChartJs 3.2.1 --> 3.5.0 (#7707)
cf041cd
@melloware
Copy link
Member

Reproducer for stacked group charts...

stacked-group.zip

@jarciano
Copy link

We upgraded Babylon to 6.0.0 with Primefaces 6.0.4 and the error persists.

[Charts createStackedBarModel](https://forum.primefaces.org/viewtopic.php?f=98&t=72619&p=200253#p200253)

@melloware
Copy link
Member

I just don't see how Babylon is affecting it as it should work the same in all themes like my reproducer works in Saga theme.

gtoison added a commit to gtoison/primefaces that referenced this issue Oct 11, 2022
@gtoison
doc: added renamed chart fields to the 12.0 migration guide
786fc6a 
In primefaces#6812 org.primefaces.model.charts.line.LineChartDataSet attributes
lineTension and lineStepped were renamed to tension and stepped
respectively.
This requires client code to be updated when migrating to primefaces 12
@gtoison gtoison mentioned this issue Oct 11, 2022
Merged
melloware pushed a commit that referenced this issue Oct 11, 2022
@gtoison
doc: added renamed chart fields to the 12.0 migration guide (#9298)
75b0c09 
In #6812 org.primefaces.model.charts.line.LineChartDataSet attributes
lineTension and lineStepped were renamed to tension and stepped
respectively.
This requires client code to be updated when migrating to primefaces 12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophs78 christophs78

Labels
new feature
Projects
None yet
Milestone
11.0.0
Development

Successfully merging a pull request may close this issue.

#6812 ChartJS: Upgrade to V3 christophs78/primefaces
4 participants
@tandraschko @melloware @christophs78 @jarciano