Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Drop Internet Explorer support #6956

Closed
christophs78 opened this issue Feb 5, 2021 · 21 comments · Fixed by #7418
Closed

Core: Drop Internet Explorer support #6956

christophs78 opened this issue Feb 5, 2021 · 21 comments · Fixed by #7418
Assignees
Labels
breaking-change Change is not backwards compatible
Milestone

Comments

@christophs78
Copy link
Contributor

With Internet Explorer dying in foreseeable future we may discuss dropping support with a future PrimeFaces-release.

This would allow use to use more modern JavaScript for new features and/or components. Maybe ES6 would be a proper base-level for some time.
Thanks to our integration-tests we have a good base to check compatibility against the 3 most wide-spreaded browsers. (Chrome, Safari and Firefox)

This suggestion is somehow inspired by Cagatay Civici who spoke about plans to replace JS-based animations within PrimeFaces with up2date CSS-animations.

@melloware
Copy link
Member

I know a couple of things....

  1. Microsoft has recommended people stop using IE for anything but legacy apps however it will still be supported until 2025.
  2. JQuery I believe is dropping support for IE in 4.0

@christophs78
Copy link
Contributor Author

jquery/jquery#4299 (jQuery 4 drops support for IE<11; but still supports IE11)

@christophs78
Copy link
Contributor Author

One option would be to use something like https://polyfill.io/v3/ to provide some kind of IE11-backwards-compatibility.

@Rapster Rapster changed the title Discussion: drop Internet Explorer - support (at some point) ... and use more modern JavaScript for new features Core: Drop Internet Explorer support Feb 6, 2021
@melloware
Copy link
Member

In my opinion once we decide to drop IE support we should rip out all blocks of code where PrimeFaces.env.isIE is found and just rip the band aid off. :) Like the JQuery team said "If someone still needs IE support they can stay on JQuery 3(aka PrimeFaces 8)."

@pizzi80
Copy link

pizzi80 commented Feb 8, 2021

The FileUpload could use directly js FormData instead of ajax with iframe

@tandraschko
Copy link
Member

FormData is already partly used

@martin654
Copy link

@melloware
You said "Microsoft has recommended people stop using IE for anything but legacy apps however it will still be supported until 2025.". Do you please have source of this information? I haven't find this myself... Thank you

@pizzi80
Copy link

pizzi80 commented Feb 9, 2021

IMHO whatever the EOL of IE I think it's time to enter the ES6 / CSS 3 era

Primefaces it's getting huge in Java / JS and CSS size to support the 1% of population

May be the v11 could remove all old Java / JSF / JS / CSS hacks and target for

JSF 3+
Java 11+
JS ES6
CSS 3

I think that for Primetek it could be also a business oppportunity to offer an LTS legacy version
for old browser and stack with a subscription based license and leave the rest of the world to develop modern software

@tandraschko
Copy link
Member

tandraschko commented Feb 9, 2021

JSF3+ and Java11+ doesnt bring any benefit currently
JSF4+ will be a bigger change then.
But we will remove JSF 2.0 support, so we can cleanup our UIData.

@pizzi80
Copy link

pizzi80 commented Feb 9, 2021

@tandraschko I really wanted to write JSF4 then I corrected myself to not look too aggressive :)

@melloware
Copy link
Member

@martin654 To answer.

Countdown: https://death-to-ie11.com/

When it boils down to it, IE11's support is tied to Windows 10 - which will see its mainstream support ending Oct. 13, 2020, and its extended support ending Oct. 14, 2025. It's likely that both of those dates will get pushed further to the right as Microsoft has a history of extending support for operating systems.

"Microsoft really doesn’t want you to use Internet Explorer anymore": https://www.theverge.com/2019/2/8/18216767/microsoft-internet-explorer-warning-compatibility-solution

"Microsoft Stops IE11 support for Office 365 in August 2021": https://www.theverge.com/2020/8/17/21372487/microsoft-internet-explorer-11-support-end-365-legacy-edge

@melloware melloware added discussion Item needs to be discussed by core devs and removed question labels Mar 20, 2021
@melloware
Copy link
Member

Microsoft has bumped up the timeline...

https://bit.ly/341JvuE

"the Internet Explorer 11 desktop application will be retired and go out of support on June 15, 2022, for certain versions of Windows 10."

@melloware
Copy link
Member

Also remove the IE function in the Java class AgentUtils.

@melloware melloware linked a pull request Jun 11, 2021 that will close this issue
@melloware melloware self-assigned this Jun 11, 2021
@melloware melloware added this to the 11.0.0 milestone Jun 11, 2021
melloware added a commit to melloware/primefaces that referenced this issue Jun 11, 2021
@jepsar
Copy link
Member

jepsar commented Jul 28, 2021

If IE is dropped we could DRY up CSS using the :is() pseudo selector

https://caniuse.com/css-matches-pseudo
https://developer.mozilla.org/en-US/docs/Web/CSS/:is

@tandraschko
Copy link
Member

we discussed this today in our company and IE11 end of life seems to be 06/2022

@tandraschko tandraschko removed this from the 11.0.0 milestone Jul 28, 2021
@melloware melloware added this to the 12.0.0 milestone Aug 30, 2021
@tandraschko
Copy link
Member

even 01-2023:
Even IE11 running on Windows 7 will be supported longer than next June. Commercial customers who pay for the third year of Extended Security Updates (ESUs) will receive support for IE through the end of that contract, or until Jan. 10, 2023.

@tandraschko tandraschko removed this from the 12.0.0 milestone Dec 14, 2021
@pizzi80
Copy link

pizzi80 commented Dec 14, 2021

Angular do not support IE so PrimeNG do not support IE

angular/angular#41840

just saying... but, If people is comfortable to pay for IE11 it should be comfortable to pay a PrimeFaces "legacy" or "LTS" version even double the price of the current version....

@melloware
Copy link
Member

React doesn't support it either without a 3rd party library react-app-polyfill.

@tandraschko
Copy link
Member

i need IE support personally until support ends, so...

@melloware melloware added this to the Future milestone May 15, 2022
@melloware melloware added breaking-change Change is not backwards compatible and removed discussion Item needs to be discussed by core devs labels May 21, 2022
@melloware melloware modified the milestones: Future, 13.0.0 May 21, 2022
@jepsar
Copy link
Member

jepsar commented Jun 14, 2022

Support ends tomorrow 😅

But... "Internet Explorer mode in Microsoft Edge enables backward compatibility and will be supported through at least 2029".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Change is not backwards compatible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants