Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu: Respect iconPos attribute #9343

Closed
melloware opened this issue Oct 26, 2022 · 0 comments · Fixed by #9344
Closed

Menu: Respect iconPos attribute #9343

melloware opened this issue Oct 26, 2022 · 0 comments · Fixed by #9344
Assignees
@melloware
Labels
enhancement Additional functionality to current component
Milestone
13.0.0

Comments

@melloware
Copy link
Member

Currently the MenuItem has the iconPos property but I can find no where in the code it is being used or respected.

For example:

<p:menuitem value="My Site" icon="pi pi-fw pi-external-link" iconPos="right"/>
<p:menuitem value="Help" icon="pi pi-fw pi-external-link" iconPos="right"/>

Renders like this...
image

Instead of this...
image

cc @FlipWarthog
@melloware melloware self-assigned this Oct 26, 2022
@melloware melloware added the enhancement Additional functionality to current component label Oct 26, 2022
@melloware melloware added this to the 13.0.0 milestone Oct 26, 2022
@melloware melloware mentioned this issue Oct 26, 2022
Merged
melloware added a commit to melloware/primefaces that referenced this issue Oct 26, 2022
@melloware
Fix primefaces#9343: MenuItem respect iconPos
e94d167
melloware added a commit that referenced this issue Oct 28, 2022
@melloware
Fix #9343: MenuItem respect iconPos (#9344)
18ca601
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
enhancement Additional functionality to current component
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

Fix #9343: MenuItem respect iconPos melloware/primefaces
1 participant
@melloware