Graphic Image: Since PF 12 ismap attribute is rendered and causing invalid HTML

[Bukama]

Describe the bug

Since Primefaces 12 the Graphic Image renderes a ismap attribute with the values true or false, resulting in invalid HTML:

While the ismap attribute is allowed on the image-tag and it is a boolean type, the correct syntax is to only add ismap when the image is a server side map and don't use it, when the image is not map, see this example from W3C:

<a href="/action_page.php">
  <img src="w3html.gif" alt="W3Schools.com" width="100" height="132" ismap>
</a>

If I've read the commit history right, the change was introduced with commit f08ba1e3d57cc82b1a07f3a4ebb2098eec532e15 in PR #8772 to fix #7943.

Reproducer

Check showcase of Graphic Image

Expected behavior

• The ismap attribute is only rendered when true
• The ismap attribute is rendered as definied by the W3C, meaning without a value

PrimeFaces edition

Community

PrimeFaces version

12.0.0

Theme

No response

JSF implementation

All

JSF version

2.2

Java version

8

Browser(s)

all

[melloware]

Duplicate of: #9369

[Bukama]

Oh sorry, I had the task to create an issue laying on my desk for about two weeks and didn't double checked if there was an issue created in the meantime :(

[melloware]

No problem!

[melloware]

I better test the TRUE scenario I fixed the false scenario.

[melloware]

This PR makes it render correctly with false and true.

	<img id="j_id_90" src="/showcase/javax.faces.resource/images/nature/nature4.jpg.xhtml?ln=demo">
	<img id="j_id_91" src="/showcase/javax.faces.resource/images/nature/nature4.jpg.xhtml?ln=demo" ismap="ismap">

ismap="ismap" is the JSF XHTML way of rendering booleans and still passes the NuHTML checker as valid.