New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VirusScan: Provide defaults for host and port #9437
Comments
tuerker
added a commit
to tuerker/primefaces
that referenced
this issue
Nov 23, 2022
tuerker
added a commit
to tuerker/primefaces
that referenced
this issue
Nov 23, 2022
tuerker
added a commit
to tuerker/primefaces
that referenced
this issue
Nov 23, 2022
tuerker
added a commit
to tuerker/primefaces
that referenced
this issue
Nov 23, 2022
tuerker
added a commit
to tuerker/primefaces
that referenced
this issue
Nov 23, 2022
tuerker
added a commit
to tuerker/primefaces
that referenced
this issue
Nov 23, 2022
melloware
pushed a commit
that referenced
this issue
Nov 23, 2022
* DataTable: Support for row-specific titles #9395 * DataTable: Support for row-specific titles #9395 * DataTable: Support for row-specific titles #9395 * DataTable: Support for row-specific titles #9395 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437
tuerker
added a commit
to tuerker/primefaces
that referenced
this issue
Nov 24, 2022
melloware
pushed a commit
that referenced
this issue
Nov 24, 2022
…x) (#9444) * DataTable: Support for row-specific titles #9395 * DataTable: Support for row-specific titles #9395 * DataTable: Support for row-specific titles #9395 * DataTable: Support for row-specific titles #9395 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 (revert)
tuerker
added a commit
to tuerker/primefaces
that referenced
this issue
Nov 24, 2022
…en ClamDaemonScanner is used without having a FacesContext)
tuerker
added a commit
to tuerker/primefaces
that referenced
this issue
Apr 5, 2023
…with default values when FacesContext is not set
tandraschko
pushed a commit
that referenced
this issue
Apr 5, 2023
…lt values when FacesContext is not set (#9995) * DataTable: Support for row-specific titles #9395 * DataTable: Support for row-specific titles #9395 * DataTable: Support for row-specific titles #9395 * DataTable: Support for row-specific titles #9395 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 (revert) * VirusScan: Provide defaults for host and port #9437 (fix when ClamDaemonScanner is used without having a FacesContext) * #9437 VirusScan: NP check included to use ClamDaemonClient with default values when FacesContext is not set
melloware
pushed a commit
that referenced
this issue
Feb 20, 2024
* DataTable: Support for row-specific titles #9395 * DataTable: Support for row-specific titles #9395 * DataTable: Support for row-specific titles #9395 * DataTable: Support for row-specific titles #9395 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 (revert) * VirusScan: Provide defaults for host and port #9437 (fix when ClamDaemonScanner is used without having a FacesContext) * #9437 VirusScan: NP check included to use ClamDaemonClient with default values when FacesContext is not set * Typo fixes and consistent usage of e.g. („exempli gratia“) followed by a comma * Consolidate the two "File Upload" subsections in the PF14 migration document
melloware
pushed a commit
that referenced
this issue
Feb 20, 2024
* DataTable: Support for row-specific titles #9395 * DataTable: Support for row-specific titles #9395 * DataTable: Support for row-specific titles #9395 * DataTable: Support for row-specific titles #9395 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 (revert) * VirusScan: Provide defaults for host and port #9437 (fix when ClamDaemonScanner is used without having a FacesContext) * #9437 VirusScan: NP check included to use ClamDaemonClient with default values when FacesContext is not set * Typo fixes and consistent usage of e.g. („exempli gratia“) followed by a comma * Consolidate the two "File Upload" subsections in the PF14 migration document * Extend file upload migration documentation
tandraschko
pushed a commit
that referenced
this issue
Feb 20, 2024
* DataTable: Support for row-specific titles #9395 * DataTable: Support for row-specific titles #9395 * DataTable: Support for row-specific titles #9395 * DataTable: Support for row-specific titles #9395 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 (revert) * VirusScan: Provide defaults for host and port #9437 (fix when ClamDaemonScanner is used without having a FacesContext) * #9437 VirusScan: NP check included to use ClamDaemonClient with default values when FacesContext is not set * Typo fixes and consistent usage of e.g. („exempli gratia“) followed by a comma * Consolidate the two "File Upload" subsections in the PF14 migration document * Extend file upload migration documentation * Migrate deprecated attributes of file upload component
melloware
added a commit
that referenced
this issue
Feb 23, 2024
) * DataTable: Support for row-specific titles #9395 * DataTable: Support for row-specific titles #9395 * DataTable: Support for row-specific titles #9395 * DataTable: Support for row-specific titles #9395 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 * VirusScan: Provide defaults for host and port #9437 (revert) * VirusScan: Provide defaults for host and port #9437 (fix when ClamDaemonScanner is used without having a FacesContext) * QRCode: NPE #9581 * #9437 VirusScan: NP check included to use ClamDaemonClient with default values when FacesContext is not set * Typo fixes and consistent usage of e.g. („exempli gratia“) followed by a comma * Consolidate the two "File Upload" subsections in the PF14 migration document * Extend file upload migration documentation * Migrate deprecated attributes of file upload component * Extend invalid file type message by printing allowed types value * Extend invalid file type message by printing allowed types value * Extend invalid file type message by printing allowed types value * Extend invalid file type message by printing allowed types value. Also added messages entries for German und Turkish. * Extend invalid file type message by printing allowed types value * Extend invalid file type message by printing allowed types value * Replaced all 'jpe?g' pattern by 'jpeg|jpg' to make the printing allowed types value more "human-readable" since this value is now printed in the validation error message * revert * cosmetics * cosmetics * #11473 further improved the invalidType message * cosmetics * cosmetics * add missing java doc * add missing java doc * add missing java doc * add missing java doc * add missing java doc * revert "unnecessary" changes * Update validation.validators.js --------- Co-authored-by: Melloware <mellowaredev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Provide defaults for host and port such that no explicit configuration in web.xml is needed anymore when these defaults are fine.
Actually by looking deeper into this issue, I also detected a bug that the
primefaces.fileupload.CLAM_AV_FILE
message is not correct since '{0}' cannot be replaced by the standard message formatter. here, the message should include ''{0}'' instead of '{0}'.
I will provide a PR immediately, implementing/fixing both issue and even generalizing the ClamDeamonScanner such that the implementation of a custom ClamDeamonScanner allows to access all virusscan paramters from the ClamDaemonClient.
Describe the solution you would like
As the other virus scan context parameter, make also host and port optional by providing according defaults:
Additional context
No response
The text was updated successfully, but these errors were encountered: