DefaultStreamedContent.contentLength is Integer

[morvael]

I think Long would be better for bigger files.

[tandraschko]

see ExternalContext:

public void setResponseContentLength(int length) {

[morvael]

I have a 5GB file to push through it, and it gets cut off at 2GB. What can be done?

[morvael]

See

	setContentLengthLong

setContentLengthLong

[morvael]

ExternalContext says it must push it through ServletResponse and ServletResponse now has the correct method for longs.

[morvael]

Seems like a fckp of the ExternalContext guys.

[morvael]

Can you get to ServletResponse bypassing ExternalContext?

[tandraschko]

https://docs.oracle.com/javaee/7/api/javax/faces/context/ExternalContext.html#setResponseContentLength-int-

[tandraschko]

I think you should create a faces specification issue first
we rely on faces api and try to avoid direct servlet calls as we also need to care about porlets

[morvael]

Yes: "Servlet: This must be performed by calling the javax.servlet.http.HttpServletResponse setContentLength method."
but ServletResponse has now new method for Long length.

[morvael]

I think you should create a faces specification issue first we rely on faces api and try to avoid direct servlet calls as we also need to care about porlets

And wait a few years? I think I need a hack around your code and ExternalContext as well for today (business reality). Do you have an idea how?

[tandraschko]

Faces 4.0 is on the track, might be a good chance currently to get it in

[tandraschko]

i would copy StreamedContentHandler in your project in the same package, so yours is used

[morvael]

Somehow I guess I need to be able to override FileDownloadActionListener.regularDownload and plug my implementation if that's possible?

[morvael]

i would copy StreamedContentHandler in your project in the same package, so yours is used

Clever. What about the other place I saw StreamedContent.getContentLength used?

[morvael]

I hope this will be enough:
jakartaee/faces#1764

[melloware]

From BalusC: FYI: work around: ec.setResponseHeader("Content-Length", String.valueOf(contentLengthLong)). Has been in among others OmniFaces Faces#sendFile() for ages.

[morvael]

Not very helpful if all I have to work with p:fileDownload and StreamedContent is Integer contentLength. That part of PF API needs enchancement too, in anticipation of JSF API enchancement. Basically the workaround is only for PF internal classes, not for someone using PF API.

[morvael]

1. you change StreamedContent from Integer to Long
2. temporarily you use setResponseHeader workaround in FileDownloadActionListener and StreamedContentHandler
3. once JSF API 4.0 is ready you switch from workaround to new Long methods in same classes, without affecting PF users

That seems like a good plan for me :)

[melloware]

agreed care to submit a PR?

[morvael]

Lol, now I'll become a laughingstock for not knowing how you submit a PR. As for code modification, I can do it. Plus there's a decision to make whether keep old methods in StreamedContent and add Long ones, or just change existing ones to Long.

[morvael]

Quickly, I can provide only this (changed files in zip):
primefaces.zip

Issues:

• DefaultStreamedContent serialized form changes
• classes extending DefaultStreamedContent may not work correctly without overriding getContentLengthLong (wondered about default implementation in StreamedContent, but don't remember what is your lowest supported Java version, plus it doesn't help when extending DefaultStreamedContent which has its own implementation).

[melloware]

@morvael i will take a look.

[melloware]

PR submitted using OmniFaces trick.

[melloware]

Looks like BalusC just submitted this to Mojarra: eclipse-ee4j/mojarra#5187

[tandraschko]

@melloware will you take of this in MF?

[melloware]

Yep it looks like he submitted that for Mojarra 4.1 but we don't have a 4.1 can I just put it in 4.0.RC3?

[tandraschko]

oh then lets wait till we have a 4.1 branch