Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar: Change event always fired when pattern and mask is applied #9953

Closed
jungm opened this issue Mar 23, 2023 · 3 comments · Fixed by #9954
Closed

Calendar: Change event always fired when pattern and mask is applied #9953

jungm opened this issue Mar 23, 2023 · 3 comments · Fixed by #9954
Assignees
@melloware
Labels
🐞 defect Bug...Something isn't working
Milestone
13.0.0

Comments

@jungm
Copy link
Contributor

jungm commented Mar 23, 2023

Describe the bug

A p:calendar with a pattern and mask fires a change event when leaving the input even though no changes were made

Reproducer

see jungm@c7b33ae

Expected behavior

This event should only be fired when the input was actually changed

PrimeFaces edition

Community

PrimeFaces version

13.0.0-SNAPSHOT

Theme

No response

JSF implementation

Mojarra

JSF version

2.3

Java version

11

Browser(s)

No response
@jungm jungm added ‼️ needs-triage Issue needs triaging 🐞 defect Bug...Something isn't working labels Mar 23, 2023
@jungm jungm mentioned this issue Mar 23, 2023
Merged
@melloware
Copy link
Member

I think its related to this issue: #9819

Have you tried it with 13.0.0-SNAPSHOT?

@melloware melloware removed the ‼️ needs-triage Issue needs triaging label Mar 23, 2023
@jungm
Copy link
Contributor Author

jungm commented Mar 23, 2023

This is reproducible on the latest 13.0.0-SNAPSHOT - the CI run for my PR #9954 just failed (as expected)

@melloware melloware self-assigned this Mar 23, 2023
@melloware melloware added this to the 13.0.0 milestone Mar 23, 2023
melloware added a commit to jungm/primefaces that referenced this issue Mar 23, 2023
@melloware
Fix primefaces#9953: Calendar blur on input mask
6352c0a
@melloware
Copy link
Member

I just pushed a fix to your branch lets see if the IT passes now...

melloware added a commit that referenced this issue Mar 23, 2023
@jungm @melloware
Fix #9953: Calendar fix mask blur event (#9954)
5d35f02 
* Calendar: IT for leaving masked input without changes

* Fix #9953: Calendar blur on input mask

---------

Co-authored-by: Melloware <mellowaredev@gmail.com>
@jungm jungm mentioned this issue Apr 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
🐞 defect Bug...Something isn't working
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

Fix #9953: Calendar fix mask blur event jungm/primefaces
2 participants
@melloware @jungm