Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #11447: Dashboard var attribute #11453

Merged
merged 1 commit into from Feb 19, 2024
Merged

Fix #11447: Dashboard var attribute #11453

merged 1 commit into from Feb 19, 2024

Conversation

melloware
Copy link
Member

Fix #11447: Dashboard var attribute

@melloware melloware added the enhancement Additional functionality to current component label Feb 17, 2024
@melloware
Copy link
Member Author

@tandraschko I love your ComponentUtils.executeInRequestScope i wonder if we should refactor more code in 15 to use it? We do this request scope variable code in a LOT of places. I an create a backlog ticket for 15.0.0 if you think its worth it?

@tandraschko
Copy link
Member

+1

i like the method too but the exception handling isnt nice
so i would not do a mass-refactor here

@melloware melloware merged commit a3feca0 into primefaces:master Feb 19, 2024
10 checks passed
@melloware melloware deleted the PF11447-dashboard branch February 19, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Additional functionality to current component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dashboard: with dynamic panels
2 participants
@melloware @tandraschko