Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #11569: Core JS setGlobalLocaleValue #11604

Merged
merged 1 commit into from Mar 11, 2024
Merged

Fix #11569: Core JS setGlobalLocaleValue #11604

merged 1 commit into from Mar 11, 2024

Conversation

melloware
Copy link
Member

Fix #11569: Core JS setGlobalLocaleValue

This will work even if the value is nested in aria or any other section.

Setting a top level value

PrimeFaces.setGlobalLocaleValue('firstDayOfWeek', 1);

Setting an ARIA label:

PrimeFaces.setGlobalLocaleValue('colorpicker.CLEAR', 'Test');

@melloware melloware added the enhancement Additional functionality to current component label Mar 9, 2024
@melloware melloware added this to the 14.0.0 milestone Mar 9, 2024
@tandraschko
Copy link
Member

thanks, will test it tomorrow

@tandraschko
Copy link
Member

works fine! could you add in the docs?

@melloware
Copy link
Member Author

Yep let me add to the docs

@melloware
Copy link
Member Author

OK added whatsnew.md and localization.md comments

@melloware
Copy link
Member Author

I will merge this and release 14.0.0-RC2 tomorrow.

@tandraschko
Copy link
Member

perfect, thanks!

@melloware melloware merged commit 91f8810 into primefaces:master Mar 11, 2024
10 checks passed
@melloware melloware deleted the PF11569 branch March 11, 2024 11:40
@melloware melloware removed this from the 14.0.0 milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tandraschko tandraschko Awaiting requested review from tandraschko

Assignees

@tandraschko tandraschko

Labels
enhancement Additional functionality to current component
Projects
None yet
Milestone
No milestone
2 participants
@melloware @tandraschko