Fix #11421: Ignore ColumnRenderer helper in components using columns

[melloware]

Fix #11421: Ignore ColumnRenderer helper in components using columns

This PR does it the "better" way with a utility to wrap and restored the helper. Note we need to do this on all components that have custom "Column Rendering".

[melloware]

also i didn't know if "Stateless" was the right term since this is removing a value from the State map...

[tandraschko]

i like this more actually but it wraps IOException into FacesException, which can have drawbacks on exception handling propably
but not sure

[Rapster]

Not sure about the name, but the try/catch and the return null doesn't look nice... Use a Runnable instead, something like FailableRunnable for nicer exception handling

[melloware]

@Rapster can you give an example of how that would work? I have only use Runnable's for threading not just for a lambda wrapper?

[Rapster]

You can use Runnable just like any other functional interfaces

public static <E extends Throwable> void runInRequestScope(FacesContext context, String var, Object value, FailableRunnable<E> runnable) throws E {
    // if no var passed just execute the callback
    if (LangUtils.isBlank(var)) {
        runnable.run();
        return;
    }

    Map<String, Object> requestMap = context.getExternalContext().getRequestMap();

    Object oldValue = requestMap.put(var, value);
    try {
        runnable.run();
    }
    finally {
        if (oldValue != null) {
            requestMap.put(var, oldValue);
        }
    }
}

[melloware]

OK @Rapster i think I got it if you want to re-review

[tandraschko]

why not just a callbacks package? thats the more common way

[Rapster]

As they're just extension of java.util, it makes sense to keep them in org.primefaces.util. I don't like having a deep and wide package structure, it always end up having a mess: the flatter the better.

Callbacks at this point is just a container, but could become what Failable is (from commons-lang), we'll most probably introduce new utils in the future, and no need to create another utils

One may argue how cumbersome it is to do someting like Callbacks.FailableConsumer but you can use static import and that should solve the "problem"

[tandraschko]

all right, thats ok for me

static imports are even more mess in the most times, so lets better stay with it

[melloware]

so I am OK to merge this?? I am very happy with this PR with @Rapster help where we landed on this!

[melloware]

@Rapster how about runWithoutStateVariable since that is really what its doing?

[Rapster]

i'm fine with that

[tandraschko]

not sure about the name
its not a "state" var actually - "state "in JSF is always viewstate
better would be something like request attribute or FacesContextVar, FacesContextScopedVar

[melloware]

I changed it to runWithoutFacesContextVar