Fix #11824: AjaxStatus always hide in oncomplete

[melloware]

Fix #11824: AjaxStatus always hide in oncomplete

This answers the question asked previously...

Could anyone explain this to me?

if (event !== 'complete' || this.jq.children().filter(this.toFacetId('complete')).length) {
            this.jq.children().hide().filter(this.toFacetId(event)).show();
        }

Basically upon oncomplete we must call facets.hide() because we are done.

cc @stolp

The code is easier to read below than in the change:

    trigger: function(event, args) {
        var callback = this.cfg[event];
        if (callback) {
            callback.apply(document, args);
        }

        // Get the facet based on the event
        var facets = this.jq.children();
        var facet = facets.filter(this.toFacetId(event));

        // We have the following events:
        // 1) start
        // 2) success or error
        // 3) complete
        switch (event) {
            case 'start':
                // always hide other facets on start
                facets.hide();
                
                if (facet.length > 0) {
                    facet.show();
                }
                break;

            case 'success':
            case 'error':
                // we now expect that either a complete or success/error facet is defined
                // if no success/error is defined, lets just rely upon the complete-facet
                if (facet.length > 0) {
                    facets.hide();
                    facet.show();
                }
                break;

            case 'complete':
                var pfArgs = args[2];
                // if the current request leads in a redirect, skip hiding the previous facet (in best case this is the start-facet)
                // when a sucess/error-facet is defined, this wont work as expected as the 'redirect' information is not available before
                if (!pfArgs || pfArgs.redirect) {
                    return;
                }
                
                // #11824 we must hide all facets and show either complete or default
                facets.hide();

                // Show complete-facet if defined, else show default facet
                if (facet.length > 0) {
                    facet.show();
                }
                break;
        }
    }

the only important change is moving the hide in the complete

               // #11824 we must hide all facets and show either complete or default
               facets.hide();

[tandraschko]

we really need to some tests now
i fear breaking all the other cases now

[melloware]

I will add some tests.

[melloware]

@tandraschko added a battery of Integration tests that HELPED ME FIND A BUG!

• tests all facets including similuting an error facet since that is hard to do
• a specific test for this actual use case from @stolp

[tandraschko]

if you tested the linked issues and they work -> +1