Fix #2831: Auto adjust the width to fit content of a Dialog Framework

[culjar]

Fix #2831 issue

[tandraschko]

Could someone re-test it?

[jxmai]

Indeed, the width calculation is

primefaces/src/main/resources/META-INF/resources/primefaces/core/core.dialog.js

Line 43 in ee5cc12

frameWidth = cfg.options.contentWidth||640;

Previously, if no width is defined or even auto, the cfg.options.contentWidth will be undefined and frameWidth will always be 640px

---

However, with this PR:

Here is the main point:

The width auto is correctly set, which is nice in theory, but I don't see any visual differences as the end result

@culjar Please explain the purpose of this PR and the use case you need to address since the end result seems the same before and after the PR.

[jxmai]

I even tried to double the amount of columns and to see the width:auto can do anything better than 640px, but the end result is not desirable.

Since you need to set the width anyway to make the table above become usable, I don't see any improvement can be made by setting width:auto 🤔 .

This PR currently is +0 for me. Any other opinion is welcome 😃

[jxmai]

Review Summary:

This PR is OK, but I don't see the improvement currently. +0 for me.

If the end result indeed no differences at all after reconfirming, then -1 for me since there are more lines of code with slightly worse performance than the previous version.

At the end of the day, the end result is all that matters.

[culjar]

To me, works perfectly.

Next I put several screenshots so that you see the good functioning.

Dialog framework with datatable:

Options for open dialog:

Result in console of Chrome (You can see that it perfectly calculates the width of the iframe):

@jxmai I think the problem in your case is that you are not putting a width size to the datatable and therefore is unable to calculate it, try to set a fixed width or create a dialog framework with other components that are not datatable.

This PR works perfectly and is not +0.

[jxmai]

@culjar Could you provide a full runnable sample for us to verify again since your code in #2831 is based on part of the showcase but not complete

• You can paste the whole XHTML + bean code in here or to fork https://github.com/primefaces/primefaces-test

think the problem in your case is that you are not putting a width size to the datatable and therefore is unable to calculate it, try to set a fixed width or create a dialog framework with other components that are not datatable.

Not exactly. Please see below

[culjar]

I downloaded primefaces-test and I made the example of Dialog Framework that is in the Showcase and does not work the automatic adjustment of the width of the dialog with the solution that I proposed.

At first I tested it in a project of mine and it seemed to work, but I have realized that it is not like that, it also does it wrong.

You're right @jxmai . Sorry to have put an invalid solution.

I hope someone can solve it as soon as possible.

[tandraschko]

So we can close that PR?

[jxmai]

Yes. This PR cannot address the issue. I might take a look later, but this PR can be closed.