Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3240, #3732, #1892, #324: InputMask upgrade JS library #6062

Merged
merged 8 commits into from
Jun 29, 2020

Conversation

melloware
Copy link
Member

The only breaking change which I need to add to the WIKI is that the optional no longer starts with ? you have to wrap the optional section in [ and ] brackets.

However I have confirmed this new library fixes all of the issue listed in the commit message.

@melloware
Copy link
Member Author

@blutorange I would like to remove our custom jqueyr.maskedinput.ts and replace with the new one from DefinitelyTyped: https://www.npmjs.com/package/@types/inputmask

How do I do that?

@melloware
Copy link
Member Author

OK I think I figured it out and now I am starting to get it!

@blutorange
Copy link
Contributor

@melloware Yeah, I think you got it right: add it to the src/main/type-definitions/package.json. And since the travis build seems to have been successful, you should be good.

@melloware
Copy link
Member Author

InputMask is a large enough lib that I decided to move it out of Jquery Plugins and make it a normal widget in inputmask/inputmask.js

@melloware melloware merged commit ce03486 into primefaces:master Jun 29, 2020
@melloware melloware deleted the PF3240 branch June 29, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants