Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #8910: Optimize JS bundling #8914

Merged
merged 1 commit into from Jun 22, 2022
Merged

Fix #8910: Optimize JS bundling #8914

merged 1 commit into from Jun 22, 2022

Conversation

melloware
Copy link
Member

By changing the following things was able to significantly reduce the size of the 3 major JS files

  • Jquery Plugins only download the 35 necessary widgets
  • Calendar now contains all the hacks and Jquery DatePicker/TimePicker in its own JS file
  • Lightbox moved to its own JS file since it is deprecated
  • Datatable moved to its own JS since its the largest component at 200KB
Version jQuery Plugins Core Components
10 262 KB 55 KB 477 KB
11 363 KB 90 KB 500 KB
12 146 KB 88 KB 396 KB

cc @jacekzwroclawia @stolp @tandraschko

@melloware melloware added the ⚡ performance Performance related issue or enhancement label Jun 21, 2022
@melloware melloware linked an issue Jun 21, 2022 that may be closed by this pull request
More lightweight Primefaces #8910
Closed
@melloware melloware merged commit 174bb78 into primefaces:master Jun 22, 2022
@melloware melloware deleted the PF8910 branch June 22, 2022 12:56
@melloware melloware mentioned this pull request Aug 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tandraschko tandraschko tandraschko left review comments

Assignees
No one assigned
Labels
⚡ performance Performance related issue or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More lightweight Primefaces
2 participants
@melloware @tandraschko