Fix #9863: ContextMenu cleanup DOM events on destroy #9866
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9863: ContextMenu cleanup DOM events on destroy
This adds the ability to remove all the subscribed DOM events from the document on destroy but in the scenario in the ticket I don't see why
destroy
is not being called? cc @tandraschko maybe i just don't understand enough about thedestroy
method.