Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breakpoints variable cannot be overriden #111

Closed
Vilican opened this issue Apr 9, 2022 · 1 comment · Fixed by #112
Closed

Breakpoints variable cannot be overriden #111

Vilican opened this issue Apr 9, 2022 · 1 comment · Fixed by #112
Labels
bug Something isn't working
Milestone
3.2.0

Comments

@Vilican
Copy link
Contributor

Vilican commented Apr 9, 2022

The $breakpoints variable in _variables.scss was not declared with !default, making it impossible to add custom breakpoints when @use-ing the library.

Bug reproduction
@Vilican Vilican mentioned this issue Apr 9, 2022
Merged
@FKunz95
Copy link

FKunz95 commented Apr 11, 2022

I have already described the solution and the necessary adjustments in #52.

@mertsincan mertsincan added the bug Something isn't working label Apr 22, 2022
@mertsincan mertsincan added this to the 3.2.0 milestone Apr 22, 2022
mertsincan added a commit that referenced this issue Apr 22, 2022
@mertsincan
Fixed #111 - Make $breakpoints as default value
2fa0ba5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.2.0
Development

Successfully merging a pull request may close this issue.

Make $breakpoints as default value
3 participants
@Vilican @mertsincan @FKunz95