Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no possibility of changing the way error styles are applied to inputs #108

Open
melantser opened this issue Mar 17, 2024 · 0 comments

Comments

@melantser
Copy link

melantser commented Mar 17, 2024

Currently, input is marked as having errors using the following styles

.p-inputtext.ng-dirty.ng-invalid { @include invalid-input(); }

In my opinion, it is not entirely correct. Let's say I want to show errors only when the user performs some action, and not immediately when he changes the input.
I suggest doing the following:

.p-show-error .p-inputtext.ng-invalid { @include invalid-input(); }

In that case, I can decide when to apply the error state to inputs simply by adding .p-show-error to the parent.
Now I have to modify the theme base to achieve this result, so theme updates take a lot of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant