Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-calendar unable to select all times when time period is less than an hour #10358

Closed
jchurchley opened this issue Jun 23, 2021 · 3 comments
Closed
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@jchurchley
Copy link

jchurchley commented Jun 23, 2021

If you have a PrimeNG PRO Support subscription please post your issue at;

https://pro.primefaces.org

where our team will respond within 4 business hours.

If you do not have a PrimeNG PRO Support subscription, fill-in the report below. Please note that
your issue will be added to the waiting list of community issues and will be reviewed on a first-come first-serve basis, as a result, the support team is unable to guarantee a specific schedule on when it will be reviewed. Thank you for your understanding.

Current Queue Time for Review
Without PRO Support: ~8-12 weeks.
With PRO Support: 1 hour

I'm submitting a ... (check one with "x")

[ x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
Please demonstrate your case at stackblitz by using the issue template below. Issues without a test case have much less possibility to be reviewd in detail and assisted.

https://github-ylt3an.stackblitz.io

Current behavior
p-calender when you set a max/min date and set the initial value to within that range you not able to select all time ranges within the period when less than an hour

Expected behavior
When you step through the minutes should be a property which you can set to either increase or decrease the hour when you increment above 60 minutes or before 0 minutes.

Minimal reproduction of the problem with instructions
p-calender
Set MinDate to 8:45
Set MaxDate to 9:30
Set Inital value to 9:30

You are unable to select a time of between 8:45-8:59

What is the motivation / use case for changing the behavior?
See example above

Please tell us about your environment:
N/A

  • Angular version: 5.X
    12.0.5

  • PrimeNG version: 5.X
    12.0.0

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    all

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    N/A

  • Node (for AoT issues): node --version =
    N/A

@jchurchley jchurchley changed the title Calendar unable to all times within a specified period when less than an hour p-calendar unable to all times within a specified period when less than an hour Jun 23, 2021
@jchurchley jchurchley changed the title p-calendar unable to all times within a specified period when less than an hour p-calendar unable to select all times when period is less than an hour Jun 23, 2021
@jchurchley jchurchley changed the title p-calendar unable to select all times when period is less than an hour p-calendar unable to select all times when time period is less than an hour Jun 23, 2021
@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jun 24, 2021
@jchurchley
Copy link
Author

jchurchley commented Jul 1, 2021

Alternately onMinuteChange and onHourChange could be exposed events and this issue could be handled by the user of the component

@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you reopen the issue so we can include it in our roadmap?
Please don't forget to add your feedback as a comment after reopening the issue. These will be taken into account by us and will contribute to the development of this feature. Thanks a lot for your understanding!

Best Regards,

@cetincakiroglu cetincakiroglu added this to the 17.13.0 milestone Mar 22, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Mar 22, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 22, 2024
@cetincakiroglu cetincakiroglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 22, 2024
cetincakiroglu added a commit that referenced this issue Mar 22, 2024
…hin_the_hour

#10358: fix date restriction within the hour issue
@cetincakiroglu
Copy link
Contributor

Fixed in #14196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

4 participants