Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpeedDial items visible even if MenuItem object property "visible" is false #10831

Closed
crega opened this issue Nov 10, 2021 · 0 comments · Fixed by #10832
Closed

SpeedDial items visible even if MenuItem object property "visible" is false #10831

crega opened this issue Nov 10, 2021 · 0 comments · Fixed by #10832
Assignees
Labels
LTS-FIXED-12.2.4 Fixed in PrimeNG LTS 12.2.4 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@crega
Copy link
Contributor

crega commented Nov 10, 2021

I'm submitting a ... (check one with "x")

[X] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
Please demonstrate your case at stackblitz by using the issue template below. Issues without a test case have much less possibility to be reviewd in detail and assisted.

https://stackblitz.com/edit/github-my5g8z?devtoolsheight=33&file=src/app/app.component.ts

Current behavior

When I provide model to SpeedDial of typeMenuItem[] and set visible of some element in that array to false. Speed dial overlay button is still present, disabling/enabling works as expected
Expected behavior

When I provide model to SpeedDial of typeMenuItem[] and set visible of some element in that array to false. Speed dial overlay button should not be visible
Minimal reproduction of the problem with instructions

See stackblitz URL ( dont know why cannot demonstrate , it says Error: Template parse errors: Can't bind to 'routerLinkActiveOptions' since it isn't a known property of 'a'. even I have imported RouterModule

What is the motivation / use case for changing the behavior?
Fixing bug

Please tell us about your environment:
ASP.NET WebAPI on backend, Windows Server (IIS)

  • Angular version: 12.0.1

  • PrimeNG version: 12.1.1

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

all

  • Language: [all]
@yigitfindikli yigitfindikli added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Nov 30, 2021
@yigitfindikli yigitfindikli self-assigned this Nov 30, 2021
@yigitfindikli yigitfindikli added this to the 13.0.1 milestone Nov 30, 2021
yigitfindikli added a commit that referenced this issue Nov 30, 2021
Fixed #10831 - SpeedDial items visible even if MenuItem object property "visible" is false
yigitfindikli added a commit that referenced this issue Nov 30, 2021
@yigitfindikli yigitfindikli added LTS-FIXED-12.2.4 Fixed in PrimeNG LTS 12.2.4 and removed LTS-PORTABLE labels Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-FIXED-12.2.4 Fixed in PrimeNG LTS 12.2.4 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants