Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Float Label always above dropdown when using reactive forms #10964

Closed
likwidgames opened this issue Dec 13, 2021 · 1 comment · Fixed by #11380
Closed

Float Label always above dropdown when using reactive forms #10964

likwidgames opened this issue Dec 13, 2021 · 1 comment · Fixed by #11380
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@likwidgames
Copy link

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
Please demonstrate your case at stackblitz by using the issue template below. Issues without a test case have much less possibility to be reviewd in detail and assisted.

https://stackblitz.com/edit/primeng-floatlabel-demo-duwdjg?file=src/app/app.component.html

Current behavior
Float label appears above the dropdown input when using formControlName but inside the dropdown when using (ngmodel).

Expected behavior
The label should appear INSIDE the dropdown input until it is selected, similar to how it works with ngmodel.

Minimal reproduction of the problem with instructions
https://stackblitz.com/edit/primeng-floatlabel-demo-duwdjg?file=src/app/app.component.html

What is the motivation / use case for changing the behavior?
This issue prevents our UI from being consistent with other float label inputs.

Please tell us about your environment:

  • Angular version: 5.X
    13.1.0

  • PrimeNG version: 5.X
    13.0.2

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    all

  • Language: [all | TypeScript X.X | ES6/7 | ES5]

  • all

  • Node (for AoT issues): node --version =

@cetincakiroglu
Copy link
Contributor

@cetincakiroglu cetincakiroglu added this to the 14.1.2 milestone Sep 16, 2022
@cetincakiroglu cetincakiroglu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Sep 16, 2022
cetincakiroglu added a commit that referenced this issue Sep 16, 2022
…-string-value-filled

#10964. Fix dropdown is filled when an empty text value is provided.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants