Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-tree node toggler button is shrunk until not visible if label starts to not fit the node #11039

Closed
anluik opened this issue Jan 7, 2022 · 1 comment
Assignees
Labels
LTS-FIXED-11.4.10 Fixed in PrimeNG LTS 11.4.10 LTS-FIXED-12.2.5 Fixed in PrimeNG LTS 12.2.5 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@anluik
Copy link

anluik commented Jan 7, 2022

I'm submitting a ... (check one with "x")

[ x ] bug report => Search github for a similar issue or PR before submitting
[   ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[   ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
When label of a p-tree node is long enough, the toggler button for the node is shrunk and eventually it is hidden. Pictures are from the documentation.
image
image

Expected behavior
I believe current behavior is not what anyone would expect to happen. The toggler button should not be shrunk.

Minimal reproduction of the problem with instructions
Make the label of the node, that has children, long enough to not fit the maximum width of the p-tree.

What is the motivation / use case for changing the behavior?
Without this change, every developer who faces this issue must add extra css to fix it. As I believe this behavior should not exist, it should not be necessary for me to add this extra css to my project.
My css to fix:
.p-tree { .p-tree-toggler { flex-shrink: 0; } }

  • PrimeNG version: 5.X

  • Browser: all

@anluik anluik changed the title p-tree node toggler button is shurk until not visible if label starts to not fit the node p-tree node toggler button is shrunk until not visible if label starts to not fit the node Jan 7, 2022
@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jan 12, 2022
@yigitfindikli yigitfindikli added this to the 13.0.5 milestone Jan 12, 2022
yigitfindikli added a commit that referenced this issue Jan 12, 2022
Fixed #11039 - Tree | Toggler button is shrunk until not visible if label starts to not fit the node
@yigitfindikli yigitfindikli added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working LTS-PORTABLE and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Jan 12, 2022
@yigitfindikli yigitfindikli added LTS-FIXED-12.2.5 Fixed in PrimeNG LTS 12.2.5 LTS-FIXED-11.4.10 Fixed in PrimeNG LTS 11.4.10 and removed LTS-PORTABLE labels Jan 28, 2022
@aymennsalhi
Copy link

.p-tree-toggler {
flex-shrink: 0 !important;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-FIXED-11.4.10 Fixed in PrimeNG LTS 11.4.10 LTS-FIXED-12.2.5 Fixed in PrimeNG LTS 12.2.5 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

4 participants