Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog | Scrolling breaks draggable dialog #11284

Closed
vaiso opened this issue Mar 4, 2022 · 1 comment · Fixed by #11358
Closed

Dialog | Scrolling breaks draggable dialog #11284

vaiso opened this issue Mar 4, 2022 · 1 comment · Fixed by #11358
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@vaiso
Copy link

vaiso commented Mar 4, 2022

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
https://stackblitz.com/edit/github-svmqvl?file=src/app/app.component.html

Current behavior
If a page is scrolled vertically, and a user tries to drag a draggable Dialog modal, it quickly moves to the bottom and gets stuck there.

Expected behavior
The modal should follow the user's mouse.

Minimal reproduction of the problem with instructions
See stackblitz link above.

  • Angular version: 13.0.3

  • PrimeNG version: 13.0.4

  • Browser: Chrome, Firefox

  • Language: TypeScript

@Phil-DS
Copy link

Phil-DS commented Mar 7, 2022

I've been encountering a similar issue all the way back in version 11.4.2 (Not LTS).
If the page is at the top of the screen, I can drag correctly. If I have scrolled down, vertical dragging seems disabled/huggs the bottom of the screen.

EDIT: From what it looks like, its looking like it doesn't take consideration of the scroll position of the page.

@cetincakiroglu cetincakiroglu self-assigned this Mar 30, 2022
@cetincakiroglu cetincakiroglu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Mar 30, 2022
@cetincakiroglu cetincakiroglu added this to the 13.3.2 milestone Mar 30, 2022
@cetincakiroglu cetincakiroglu changed the title Draggable Dialogs break with scrolling Dialog | Scrolling breaks draggable dialog Mar 30, 2022
yigitfindikli added a commit that referenced this issue Mar 30, 2022
Fixed #11284 - Dialog | Scrolling breaks draggable dialog
yigitfindikli added a commit that referenced this issue Mar 30, 2022
@yigitfindikli yigitfindikli self-assigned this Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants