Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong in style Password Component #11408

Closed
rezaokhravi opened this issue Apr 12, 2022 · 2 comments
Closed

wrong in style Password Component #11408

rezaokhravi opened this issue Apr 12, 2022 · 2 comments

Comments

@rezaokhravi
Copy link

#11356
https://stackblitz.com/edit/primeng-sidebar-demo-if1s7u?file=src%2Fapp%2Fapp.component.ts
volvachev pushed a commit to volvachev/primeng that referenced this issue Apr 13, 2022
fix(primeng/p-password): incorrect class assignment for true value …
45686d2 
…of `toggleMask` in the password component.

The problem appeared during fix of the bug primefaces#10716 (running `detectChanges` in `pInputText`). Detector ran a setter inside `ngClass` and did not run `doCheck` inside `ngClass`.

Fixes primefaces#11356, primefaces#11408.
volvachev added a commit to volvachev/primeng that referenced this issue Apr 13, 2022
@volvachev
fix(primeng/p-password): incorrect class assignment for true value …
33bd4f0 
…of `toggleMask` in the password component.

The problem appeared during fix of the bug primefaces#10716 (running `detectChanges` in `pInputText`). Setter has been ran by detector without running doCheck inside `ngClass`.

Fixes primefaces#11356, primefaces#11408.
@volvachev volvachev mentioned this issue Apr 13, 2022
Merged
@volvachev
Copy link
Contributor

Hi, I created a fix and an explanation of why the problem had been occurred.

@cetincakiroglu cetincakiroglu added the Status: Pending Review Issue or pull request is being reviewed by Core Team label May 30, 2022
volvachev added a commit to volvachev/primeng that referenced this issue Jun 2, 2022
@volvachev
fix(primeng/p-password): incorrect class assignment for true value …
12f6a81 
…of `toggleMask` in the password component.

The problem appeared during fix of the bug primefaces#10716 (running `detectChanges` in `pInputText`). Setter has been ran by detector without running doCheck inside `ngClass`.

Fixes primefaces#11356, primefaces#11408.
@cetincakiroglu
Copy link
Contributor

Hi,

Invalid StackBlitz url, link is broken. Cannot replicate and closing the issue. Feel free to re-open with a VALID StackBlitz example.

@cetincakiroglu cetincakiroglu removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Aug 9, 2022
mertsincan added a commit that referenced this issue Nov 8, 2022
@volvachev @mertsincan
fix(primeng/p-password): incorrect class assignment for true value …
ce1ad29 
…of `toggleMask` in the password component. (#11416)

The problem appeared during fix of the bug #10716 (running `detectChanges` in `pInputText`). Setter has been ran by detector without running doCheck inside `ngClass`.

Fixes #11356, #11408.

Co-authored-by: mertsincan <sincan.mert@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@volvachev @rezaokhravi @cetincakiroglu