Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-colorPicker onInputClick using a button not working #11438

Closed
devAzer opened this issue Apr 20, 2022 · 0 comments · Fixed by #11447
Closed

p-colorPicker onInputClick using a button not working #11438

devAzer opened this issue Apr 20, 2022 · 0 comments · Fixed by #11447
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@devAzer
Copy link

devAzer commented Apr 20, 2022

I'm submitting a ... (check one with "x")

[ ] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
When we are trying to trigger and open p-colorPicker using a button with onInputClick() colorpicker is not opening.
The same behavior worked on previous versions of primeng. For example I tested on primeng 9.1.3 and worked as expected. The Colorpicker is opening on button click.

Expected behavior
Colorpicker is opening while click on a button.

Minimal reproduction of the problem with instructions
https://stackblitz.com/edit/angular-ivy-dyuxka

Click on the color picker, and you can see color picker is opening correctly. If you click on the button, Color picker is not populating. That was not the case in the previous versions of primeng. The same code worked correctly with the previous versions.
Working example: https://stackblitz.com/edit/angular-jwvivn

What is the motivation / use case for changing the behavior?
To improve the user experience on our applications.

Please tell us about your environment:

  • Angular version:
    v13

  • PrimeNG version:
    13.3.3

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    Tested on Chrome

volvachev pushed a commit to volvachev/primeng that referenced this issue Apr 23, 2022
Fixes a bug in Primeng `colorPicker` when will try open manually by `ViewChild` ref.

Fixes primefaces#11438.
volvachev added a commit to volvachev/primeng that referenced this issue Apr 23, 2022
Fixes a bug in Primeng `colorPicker` when will try open manually by `ViewChild` ref.

Fixes primefaces#11438.
@yigitfindikli yigitfindikli added this to the 13.4.0 milestone Apr 29, 2022
@yigitfindikli yigitfindikli added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Apr 29, 2022
yigitfindikli added a commit that referenced this issue Apr 29, 2022
Fixed #11438 - p-colorPicker onInputClick using a button not working
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants