Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitbutton commands not triggered when using keyboard #11514

Closed
blackholegalaxy opened this issue May 12, 2022 · 0 comments · Fixed by #11516
Closed

Splitbutton commands not triggered when using keyboard #11514

blackholegalaxy opened this issue May 12, 2022 · 0 comments · Fixed by #11516
Assignees
Milestone

Comments

@blackholegalaxy
Copy link

**I'm submitting a **

[x ] bug report => Search github for a similar issue or PR before submitting

Repro Case (Bug Reports)
No need for template, issue on official demo page.

https://www.primefaces.org/primeng/splitbutton

Current behavior
When using tab navigation we can open the split button menu. Then we can navigate through menu items. using Enter keyboard key works well for links (because we have href attribute). But for items with a custom command => () as update or delete in the official demo page, item is not triggerable using keyboard. This can cause serious accessibility issues.

Expected behavior
We expect custom command to be triggered while using keyboard navigation for accessibility purpose.

Minimal reproduction of the problem with instructions
Go on demo page, go to first split button using tab key. Open the menu with enter or space key. Then tab to "Update" or "Delete". Hit enter -> nothing happens. The event is only triggered using click.

What is the motivation / use case for changing the behavior?
Accessibility. Prevent usage of the button for people using keyboards.

Please tell us about your environment:
All

  • Angular version: 13

  • PrimeNG version: 13.4.0

  • Browser: all
  • Language: TS
volvachev added a commit to volvachev/primeng that referenced this issue May 12, 2022
Process the keyboard `enter` event for a menu item if it is not `routerLink'.

Fixes primefaces#11514.
@cetincakiroglu cetincakiroglu self-assigned this May 23, 2022
@cetincakiroglu cetincakiroglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Status: Pending Review Issue or pull request is being reviewed by Core Team Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Status: Pending Review Issue or pull request is being reviewed by Core Team labels May 23, 2022
@cetincakiroglu cetincakiroglu added this to the 13.Future milestone May 24, 2022
@cetincakiroglu cetincakiroglu removed the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label May 24, 2022
@cetincakiroglu cetincakiroglu modified the milestones: 13.Future, 13.4.2 May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants