Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image | Zoom in and out buttons do not work properly (Firefox & Chrome) #11527

Closed
marskop opened this issue May 17, 2022 · 0 comments · Fixed by #11528
Closed

Image | Zoom in and out buttons do not work properly (Firefox & Chrome) #11527

marskop opened this issue May 17, 2022 · 0 comments · Fixed by #11528
Assignees
@cetincakiroglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
14.0.0-rc.1

Comments

@marskop
Copy link

marskop commented May 17, 2022

Current behavior
In firefox, when the user previews an image and selects to zoom out all the way, the zoom in button does not work and vice versa. While in chrome when zooming out or zooming in all the way the preview of the image closes.

Expected behavior
User should be able to zoom in and zoom out without closing the image or disabling both zooming buttons.

Minimal reproduction of the problem with instructions

  1. Visit https://www.primefaces.org/primeng/image from chrome, preview the image and zoom in/out
  2. Visit https://www.primefaces.org/primeng/image from firefox, preview the image and zoom in/out

My environment:

  • Angular version: 13.2.4

  • PrimeNG version: 13.2.0

  • Browser: [ Chrome 101.0.4951.64 | Firefox 100.0 ]

  • Language: [TypeScript 4.4.3]
volvachev pushed a commit to volvachev/primeng that referenced this issue May 17, 2022
fix(primeng/image): zoom in and out buttons
1571184 
Fixes primefaces#11527.
volvachev added a commit to volvachev/primeng that referenced this issue May 17, 2022
@volvachev
fix(primeng/image): zoom in and out buttons
17b5fc8 
Fixes primefaces#11527.
@volvachev volvachev mentioned this issue May 17, 2022
Merged
@cetincakiroglu cetincakiroglu self-assigned this May 17, 2022
@cetincakiroglu cetincakiroglu added the Status: Pending Review Issue or pull request is being reviewed by Core Team label May 17, 2022
@cetincakiroglu cetincakiroglu added this to the 13.Future milestone May 23, 2022
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels May 23, 2022
@cetincakiroglu cetincakiroglu modified the milestones: 13.Future, 13.4.2 May 24, 2022
@cetincakiroglu cetincakiroglu changed the title P-image: Zoom in and out buttons do not work properly (Firefox & Chrome) Image | Zoom in and out buttons do not work properly (Firefox & Chrome) May 24, 2022
cetincakiroglu added a commit that referenced this issue May 24, 2022
@cetincakiroglu
Merge pull request #11528 from volvachev/fix-image-preview
5e69dfa 
Fixes #11527 - Image | Zoom in and out buttons do not work properly (Firefox & Chrome)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cetincakiroglu cetincakiroglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
14.0.0-rc.1
2 participants
@marskop @cetincakiroglu