Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent checkbox state incorrect when TreeSelect is being filter #11815

Closed
bon-vivant opened this issue Aug 11, 2022 · 4 comments
Closed

Parent checkbox state incorrect when TreeSelect is being filter #11815

bon-vivant opened this issue Aug 11, 2022 · 4 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working

Comments

@bon-vivant
Copy link

Describe the bug

On TreeSelect Filter, filtering selection so that a node with multiple children options is filtered down to displaying just one child option, then selecting the child, causes the parent checkbox to display fully-selected (checked) icon instead of the partially-select (minus) icon. Clearing the filter will redisplay the other children options but parent checkbox is still showing fully-selected (checked) icon:

Bug.in.3rd.party.component.mp4

Environment

Found on

PrimeNG 14.0.0
Angular 14.1.1

but it was probably an issue in PrimeNG 13 when filter was introduced to the TreeSelect component.

Reproducer

No response

Angular version

Angular 14.1.1

PrimeNG version

14.0.0

Build / Runtime

Angular CLI App

Language

ALL

Node version (for AoT issues node --version)

16.14.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Open TreeSelect dropdown
  2. Filter a multiple children node down to so that at least one child option is filtered out
  3. Select all available children in the node until parent checkbox shows fully-selected (checked) icon
  4. Clear the filter so that all children are now visible and nothing is filtered out
  5. Observe that parent checkbox is still displaying fully-selected (checked) icon

Expected behavior

Parent checkbox should be displaying partially-selected (minus) icon either by step 3 or step 4.

If at least one but not all child options of a node are selected, parent checkbox should display partially-selected (minus) icon. Parent checkbox should only display fully-selected (checked) icon when all its children options are selected.

@bon-vivant bon-vivant added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Aug 11, 2022
@bon-vivant bon-vivant changed the title Component: Title Parent checkbox state incorrect when TreeSelect is being filter Aug 11, 2022
@cetincakiroglu cetincakiroglu added this to the 14.1.3 milestone Oct 20, 2022
@mertsincan mertsincan modified the milestones: 14.2.0, 14.2.1 Nov 8, 2022
@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you reopen the issue so we can include it in our roadmap?
Please don't forget to add your feedback as a comment after reopening the issue. These will be taken into account by us and will contribute to the development of this feature. Thanks a lot for your understanding!

Best Regards,

@mertsincan mertsincan removed this from the 14.2.2 milestone Nov 9, 2022
@ljotu
Copy link

ljotu commented Jul 20, 2023

Hello,

This is still an issue as of version 16.0.2
Tested by adding [filter]="true" to the official documentation TreeSelect checkbox Stackblitz demo

@nur-kjaeger
Copy link

@bon-vivant
Can you reopen this issue? This is still an issue in 17.6

stackblitz

@bon-vivant
Copy link
Author

I don't see a way to reopen the issue on the page (screenshot of what I'm seeing), just a Comment button (screenshot of what I'm seeing).
@mertsincan are you able to reopen the issue or should a new issue typically be created in this situation?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

6 participants