Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion Panel within an Accordion Panel is broken #11848

Closed
rosenthalj opened this issue Aug 19, 2022 · 3 comments · Fixed by #12145
Closed

Accordion Panel within an Accordion Panel is broken #11848

rosenthalj opened this issue Aug 19, 2022 · 3 comments · Fixed by #12145
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@rosenthalj
Copy link
Contributor

Describe the bug

A p-accordion within p-accordion is broken in primeNG v14.0.1.

The contents of all the p-accordionTab panels of an embedded p-accordion panel is always visible when the embedded p-accordion panel is visible

AccordionWithAccordion

AccordionAccordionBug.mov

I believe the bug was induced by #11617 commit
f849e9d

Fixed__11617_-PrimeNG_component_animation_trigger_warnings_since_upd…·_primefaces_primeng_f849e9d

Environment

Happens in both stackblitz and local project

Reproducer

https://stackblitz.com/edit/github-irxb1p?file=src%2Fapp%2Fapp.component.html,src%2Fapp%2Fapp.component.ts,src%2Fapp%2Fapp.component.spec.ts

Angular version

14.x

PrimeNG version

14.0.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

14+

Browser(s)

All Browsers

Steps to reproduce the behavior

https://github-irxb1p.stackblitz.io

  1. Expand all header tabs
  2. Randomly open and close Header A and Header B tabbed panel.
  • See that the contents of Header A and Header B are always visible

Expected behavior

Embedded PrimeNG Accordion panels work the same as non-embedded PrimeNG Accordions.

V14.x embedded p-accordion works the same as V13.x embedded p-accordion

@rosenthalj rosenthalj added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Aug 19, 2022
@rosenthalj rosenthalj changed the title Accordion Panel within a, Accordion Panel is broken Accordion Panel within an Accordion Panel is broken Aug 19, 2022
@mertsincan mertsincan added this to the 14.0.2 milestone Aug 19, 2022
@majkers
Copy link

majkers commented Aug 22, 2022

The same as #11736?

@krtek4
Copy link

krtek4 commented Sep 13, 2022

If a dropdown is bigger than the size of the accordion, its content isn't displayed entirely.

Instead of just removing the buggy css, something like that could be done :

.p-accordion-tab-active > .p-toggleable-content:not(.ng-animating) {
  overflow: visible;
}

@gerardva
Copy link

The issue with the nested Accordions seemed to be fixed in 4.1.0 but appears to occur again in 4.1.1/4.1.2, see https://stackblitz.com/edit/angular-ivy-q8x2la?file=package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants