Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataView: DataView shows Empty Message even if loading #12157

Closed
PaulSchult opened this issue Nov 9, 2022 · 1 comment · Fixed by #12158
Closed

DataView: DataView shows Empty Message even if loading #12157

PaulSchult opened this issue Nov 9, 2022 · 1 comment · Fixed by #12158
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
15.0.0

Comments

@PaulSchult
Copy link

Describe the bug

The empty message of the dataView is shown even if the loading flag is set to true.

Environment

Angular CLI: v14.2.3
PrimeNG: v14.1.2

Reproducer

https://stackblitz.com/edit/primeng-dataview-demo-gmp1n7?file=src%2Fapp%2Fapp.component.html,src%2Fapp%2Fapp.component.ts

Angular version

14.2.3

PrimeNG version

14.1.2

Build / Runtime

TypeScript

Language

TypeScript

Node version (for AoT issues node --version)

18.10.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Open Stackblitz and wait for server to start
  2. Notice the loading icon and greyish background + the red highlighted text in the background which is the empty message
  3. Both things are shown at the same time

Expected behavior

Only the loading icon should be visisble until loading is set to false. Then either the actual values or the empty message should be shown.
@PaulSchult PaulSchult added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Nov 9, 2022
PaulSchult pushed a commit to PaulSchult/primeng that referenced this issue Nov 9, 2022
fix: primefaces#12157 only show emptyMessage if dataView is not loading
1a2ae47
@PaulSchult PaulSchult mentioned this issue Nov 9, 2022
Merged
@PaulSchult
Copy link
Author

related mr #12158

@cetincakiroglu cetincakiroglu added this to the 15.Future milestone Nov 22, 2022
@cetincakiroglu cetincakiroglu modified the milestones: 15.Future, 15.0.0 Dec 2, 2022
cetincakiroglu added a commit that referenced this issue Dec 2, 2022
@cetincakiroglu
Merge pull request #12158 from PaulSchult/master
2a479aa 
fix #12157 only show emptyMessage if dataView is not loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

fix #12157 only show emptyMessage if dataView is not loading PaulSchult/primeng
2 participants
@PaulSchult @cetincakiroglu