Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Not displaying correctly in dialog after content change and dialog reopen #12195

Closed
saramcicchi opened this issue Nov 11, 2022 · 0 comments · Fixed by #12244
Closed
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@saramcicchi
Copy link

Describe the bug

This is a followup to #11814. That issue was fixed such that opening a dialog with editor content is displayed correctly. However, if you close the dialog, reset the content of the editor's form control value, and reopen the dialog, the content is not displayed correctly - its formatting is lost and it is displayed in a single paragraph HTML tag.

Environment

Applicable to versions described below

Reproducer

https://stackblitz.com/edit/primeng-editor-in-dialog-bug-qf2o4p

Angular version

14.0.7

PrimeNG version

14.2.1

Build / Runtime

Angular CLI App

Language

ALL

Node version (for AoT issues node --version)

14.21.1

Browser(s)

No response

Steps to reproduce the behavior

  1. Click the button to open the editor in a dialog -> you'll see a list
  2. Close the dialog which calls "formControl.setValue(editorContent)"
  3. Click the button to open the editor in a dialog again -> this time the list formatting isn't applied

Expected behavior

The formatting of the content of an editor in a dialog should be the same no matter how many times you change the form control's value and close/reopen the dialog.

@saramcicchi saramcicchi added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 11, 2022
volvachev added a commit to volvachev/primeng that referenced this issue Nov 17, 2022
@cetincakiroglu cetincakiroglu removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 2, 2022
@cetincakiroglu cetincakiroglu changed the title Editor: Not displaying correctly correctly in dialog after content change and dialog reopen Editor: Not displaying correctly in dialog after content change and dialog reopen Dec 2, 2022
@cetincakiroglu cetincakiroglu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Dec 2, 2022
@cetincakiroglu cetincakiroglu added this to the 15.0.0 milestone Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants