Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Badge Attribute - Size option #12205

Closed
ProfEibe opened this issue Nov 13, 2022 · 0 comments
Closed

Badge Attribute - Size option #12205

ProfEibe opened this issue Nov 13, 2022 · 0 comments
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone
15.1.0

Comments

@ProfEibe
Copy link

ProfEibe commented Nov 13, 2022 •
edited
Loading

Describe the feature you would like to see added

For the Badge-Directive option, it would also be great if there was a size-Attribute like the new disabled option.

Is your feature request related to a problem?

Using Badge as component I can set the size attribute. Using the attribute version you can't do this.

Describe the solution you'd like

Maybe like this?

<i class="pi pi-bell" pBadge [value]="user.notifications" [badgeSize]="badgeSize"></i>

Describe alternatives you have considered

No response

Additional context

#12170
@ProfEibe ProfEibe added Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: New Feature Issue contains a new feature or new component request labels Nov 13, 2022
@ProfEibe ProfEibe changed the title Component: Badge Badge Attribute - Size option Nov 13, 2022
volvachev added a commit to volvachev/primeng that referenced this issue Nov 21, 2022
@volvachev
feat(primeng/p-badge): add size attribute to badge directive
6fb62d3 
Fixes primefaces#12205.
@volvachev volvachev mentioned this issue Nov 21, 2022
Merged
@cetincakiroglu cetincakiroglu added this to the 15.0.0 milestone Nov 30, 2022
@cetincakiroglu cetincakiroglu removed Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 30, 2022
@cetincakiroglu cetincakiroglu modified the milestones: 15.0.0, 15.Future Dec 12, 2022
@cetincakiroglu cetincakiroglu modified the milestones: 15.Future, 15.0.2 Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Milestone
15.1.0
Development

No branches or pull requests
2 participants
@ProfEibe @cetincakiroglu