Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeSelect: panelClass not working #12221

Closed
xchimera opened this issue Nov 15, 2022 · 1 comment · Fixed by #12226
Closed

TreeSelect: panelClass not working #12221

xchimera opened this issue Nov 15, 2022 · 1 comment · Fixed by #12226
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@xchimera
Copy link

Describe the bug

It seems that the panelClass attribute is not being used. I expect that the class i set in the panelClass is a class that is being set on https://github.com/primefaces/primeng/blob/805d88b385f5fe606af591a6e8e6f5ea8107da65/src/app/components/treeselect/treeselect.ts#L49
In the latest version for angular 13 (primeng 13.4.1) that is not the case, as seems evident in treeselect.cs

Environment

angular 13.3.11
PrimeNG 13.4.1

Reproducer

https://stackblitz.com/edit/github-wjckhs?file=src/app/app.component.html

Angular version

13.3.11

PrimeNG version

13.4.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16.15.1

Browser(s)

No response

Steps to reproduce the behavior

Add a p-treeSelect and add a panelClass property. In DevTools it can be seen that this class is never attached to the element. Looking at the source code it is unused

Expected behavior

That the opened panel has the class attached

@xchimera xchimera added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 15, 2022
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 16, 2022
@cetincakiroglu cetincakiroglu self-assigned this Nov 16, 2022
@cetincakiroglu cetincakiroglu added this to the 14.2.2 milestone Nov 16, 2022
cetincakiroglu added a commit that referenced this issue Nov 16, 2022
Fixed #12221 - TreeSelect: panelClass not working
@xchimera
Copy link
Author

Awesome with a quick fix. Is it possible to create a 13.4.2 with this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants