Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar: wrong logic of disabling the month #12330

Closed
RTcyan opened this issue Dec 5, 2022 · 0 comments · Fixed by #12338
Closed

Calendar: wrong logic of disabling the month #12330

RTcyan opened this issue Dec 5, 2022 · 0 comments · Fixed by #12338
Assignees
@RTcyan
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
15.0.1

Comments

@RTcyan
Copy link

RTcyan commented Dec 5, 2022

Describe the bug

If we enter min date greater then the first day of month, we won't be able to choose that month in the "month view" of calendar.
Example: minDate = 02.12.2022, December is not able to select
image
image

Environment

  • macOS: 13.0

Reproducer

https://stackblitz.com/edit/primeng-calendar-demo-s6vvzw?file=src/app/app.component.ts

Angular version

14.0.0

PrimeNG version

14.2.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16.17.0

Browser(s)

Google Chrome 107.0

Steps to reproduce the behavior

No response

Expected behavior

Even if one day is selectable, so month is selectable also
@RTcyan RTcyan added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 5, 2022
RTcyan pushed a commit to RTcyan/primeng that referenced this issue Dec 6, 2022
primefaces#12330 Fix logic of disable months in month picker
56bea44
RTcyan pushed a commit to RTcyan/primeng that referenced this issue Dec 6, 2022
primefaces#12330 write additional test for datepicker
c9bb445
@RTcyan RTcyan mentioned this issue Dec 6, 2022
Merged
RTcyan pushed a commit to RTcyan/primeng that referenced this issue Dec 6, 2022
primefaces#12330 fix logic of month disable
f272386
RTcyan pushed a commit to RTcyan/primeng that referenced this issue Dec 6, 2022
primefaces#12330 fix test
a9828d3
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 29, 2022
@cetincakiroglu cetincakiroglu added this to the 15.0.1 milestone Dec 29, 2022
cetincakiroglu added a commit that referenced this issue Jan 2, 2023
@cetincakiroglu
Merge pull request #12338 from RTcyan/issue-12330
b8de03a 
#12330 Fix logic of disable months in month picker
@cetincakiroglu cetincakiroglu mentioned this issue Jan 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RTcyan RTcyan

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
15.0.1
Development

Successfully merging a pull request may close this issue.

#12330 Fix logic of disable months in month picker RTcyan/primeng
2 participants
@RTcyan @cetincakiroglu