Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table: pReorderableRowHandle directive generates error TS2322: Type 'string' is not assignable to type 'number' #12416

Closed
KeithGillette opened this issue Dec 22, 2022 · 0 comments · Fixed by #12472
Closed

Table: pReorderableRowHandle directive generates error TS2322: Type 'string' is not assignable to type 'number' #12416

KeithGillette opened this issue Dec 22, 2022 · 0 comments · Fixed by #12472
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
15.1.0

Comments

@KeithGillette
Copy link
Contributor

Describe the bug

With tsconfig.json > angularCompilerOptions.strictTemplates: true, including pReorderableRowHandle on a production build fails with error TS2322: Type 'string' is not assignable to type 'number'

Environment

See below.

Reproducer

No response

Angular version

14.2.7

PrimeNG version

14.1.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16.17.0

Browser(s)

N/A

Steps to reproduce the behavior

  1. Use pReorderableRowHandle in a template containing Table as shown in the PrimeNG showcase in an Angular project with tsconfig.json > angularCompilerOptions.strictTemplates: true
  2. Perform a production build

Expected behavior

The application should compile without error.
@KeithGillette KeithGillette added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 22, 2022
volvachev added a commit to volvachev/primeng that referenced this issue Jan 9, 2023
@volvachev
fix(primeng/p-table): remove unused @Input for pReorderableRowHandle
969da38 
Fixes primefaces#12416.
@volvachev volvachev mentioned this issue Jan 9, 2023
Merged
@cetincakiroglu cetincakiroglu added this to the 15.0.2 milestone Jan 9, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
15.1.0
Development

Successfully merging a pull request may close this issue.

fix(primeng/p-table): remove unused @Input for pReorderableRowHandle volvachev/primeng
2 participants
@KeithGillette @cetincakiroglu