Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button | incorrect work with dynamic classes #12456

Closed
ValentinKrigovsky opened this issue Jan 4, 2023 · 3 comments · Fixed by #12471
Closed

Button | incorrect work with dynamic classes #12456

ValentinKrigovsky opened this issue Jan 4, 2023 · 3 comments · Fixed by #12471
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
15.1.0

Comments

@ValentinKrigovsky
Copy link
Contributor

Describe the bug

p-button's loading directive sets p-disabled on button, but after loading is set back to false, p-loading and p-disabled stays on button, causing it to not be clickable

Environment

tried it directly in primeng project, not working

Reproducer

No response

Angular version

15

PrimeNG version

15

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16

Browser(s)

chrome

Steps to reproduce the behavior

go to any p-buttons template, set loading to true, after some time set to false, you will see loading icon dissapear but disabled style will stay

Expected behavior

after loading is done, remove p-loading and p-disabled from buttons styles
@ValentinKrigovsky ValentinKrigovsky added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 4, 2023
@PedroLima8080
Copy link

same here!

@michfelip
Copy link

Having the same issue here as well.

@pablo191f
Copy link

Same issue here, PrimeNG 15.0.1. It was working on version 14.x.

volvachev added a commit to volvachev/primeng that referenced this issue Jan 9, 2023
@volvachev
fix(primeng/p-button): incorrect work with dynamic classes, fixed dup…
626eedc 
…lication classes

Fixes primefaces#12456.
@volvachev volvachev mentioned this issue Jan 9, 2023
Merged
volvachev added a commit to volvachev/primeng that referenced this issue Jan 9, 2023
@volvachev
fix(primeng/p-button): incorrect work with dynamic classes, fixed dup…
dfa8e46 
…lication classes

Fixes primefaces#12456.
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 12, 2023
@cetincakiroglu cetincakiroglu added this to the 15.0.2 milestone Jan 12, 2023
@cetincakiroglu cetincakiroglu changed the title Component: p-button Button | incorrect work with dynamic classes Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
15.1.0
5 participants
@pablo191f @michfelip @PedroLima8080 @cetincakiroglu @ValentinKrigovsky