Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlay | close on escape key #12474

Closed
AjeetUI opened this issue Jan 9, 2023 · 0 comments · Fixed by #12476
Closed

Overlay | close on escape key #12474

AjeetUI opened this issue Jan 9, 2023 · 0 comments · Fixed by #12476
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone
15.1.0

Comments

@AjeetUI
Copy link

AjeetUI commented Jan 9, 2023

Describe the bug

I want to close prime overlay on escape key
Please suggest any solution if possible in current stable version.

Environment

Prime overlay close on escape key

Reproducer

No response

Angular version

14.1.1

PrimeNG version

14.0.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

14.20

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@AjeetUI AjeetUI added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 9, 2023
volvachev pushed a commit to volvachev/primeng that referenced this issue Jan 10, 2023
feat(primeng/p-overlay): add listener for close overlay by escape key
aca86e4 
Fixes primefaces#12474.
volvachev added a commit to volvachev/primeng that referenced this issue Jan 10, 2023
@volvachev
feat(primeng/p-overlay): add listener for close overlay by escape key
2bcb944 
Fixes primefaces#12474.
@volvachev volvachev mentioned this issue Jan 10, 2023
Merged
@cetincakiroglu cetincakiroglu added Type: New Feature Issue contains a new feature or new component request and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 11, 2023
@cetincakiroglu cetincakiroglu modified the milestones: 15.Future, 15.0.2 Jan 11, 2023
volvachev added a commit to volvachev/primeng that referenced this issue Jan 12, 2023
@volvachev
feat(primeng/p-overlay): add listener for close overlay by escape key
a221200 
Fixes primefaces#12474.
volvachev added a commit to volvachev/primeng that referenced this issue Jan 12, 2023
@volvachev
feat(primeng/p-overlay): add listener for close overlay by escape key
afaad0f 
Fixes primefaces#12474.
@cetincakiroglu cetincakiroglu changed the title Title - Prime overlay close on escape key Overlay | close on escape key Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Milestone
15.1.0
Development

Successfully merging a pull request may close this issue.

feat(primeng/p-overlay): add listener for close overlay by escape key volvachev/primeng
2 participants
@cetincakiroglu @AjeetUI