Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p-button: disabled p-button doesn't work #12692

Closed
theophane-girard opened this issue Mar 1, 2023 · 4 comments
Closed

p-button: disabled p-button doesn't work #12692

theophane-girard opened this issue Mar 1, 2023 · 4 comments
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
16.3.0

Comments

@theophane-girard
Copy link

theophane-girard commented Mar 1, 2023 •
edited

Describe the bug

We can click on disabled buttons when using p-button tag:

stackblitz

disabled works only when using directive

Even if the doc says to use onClick instead of angular native (click), we shouldn't be able to click on a disabled button

Environment

basic app

Reproducer

https://stackblitz.com/edit/angular-zkup5y?file=src/main.ts

Angular version

15.2

PrimeNG version

15.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

latest

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@theophane-girard theophane-girard added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 1, 2023
@jucasoft
Copy link

jucasoft commented Mar 3, 2023 •
edited

#12495 same problem

volvachev added a commit to volvachev/primeng that referenced this issue Mar 4, 2023
@volvachev
fix(primeng/p-button): add disable class on host element
16317a6 
Fixes primefaces#12495, primefaces#12692.
@volvachev volvachev mentioned this issue Mar 4, 2023
Merged
@rcollette
Copy link

Duplicate of #12495

@nur-psoehnlein
Copy link

I fell into the same trap and expected (click) to just work (like (onClick), which I wasn't aware of until I looked in the issue tracker). That's actually my fault, but I think it's a common one and maybe the PrimeNG folks might consider adjusting this behaviour.

mertsincan pushed a commit that referenced this issue Aug 18, 2023
@volvachev
fix(primeng/p-button): add disable class on host element (#12704)
919f892 
Fixes #12495, #12692.
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 18, 2023
@mertsincan mertsincan added this to the 16.2.1 milestone Aug 18, 2023
@mertsincan
Copy link
Member

Fixed in 919f892

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
16.3.0
Development

No branches or pull requests
5 participants
@rcollette @jucasoft @theophane-girard @mertsincan @nur-psoehnlein