Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular SSR Support - Multiple Components #12734

Closed
EnricoMessall opened this issue Mar 10, 2023 · 0 comments · Fixed by #12735
Closed

Angular SSR Support - Multiple Components #12734

EnricoMessall opened this issue Mar 10, 2023 · 0 comments · Fixed by #12735
Assignees
@cetincakiroglu
Labels
Angular Universal Issue or pull request is related to Angular Universal Server Side Rendering Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
15.3.0

Comments

@EnricoMessall
Copy link
Contributor

Describe the bug

Some components use the document variable. That results in some errors for Angular SSR Rendering and can be easily handled by using the @Inject for the Angular Document Variable what is already used in some other components.

Environment

Basic Angular CLI App with PrimeNG and NG Universal

Reproducer

No response

Angular version

15.1.0

PrimeNG version

15.1.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16.16.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@EnricoMessall EnricoMessall added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 10, 2023
EnricoMessall added a commit to Arematics/primeng that referenced this issue Mar 10, 2023
@EnricoMessall
Issue primefaces#12734
659ec0c 
 + Using Document Inject for Angular SSR
EnricoMessall added a commit to Arematics/primeng that referenced this issue Mar 10, 2023
@EnricoMessall
Issue primefaces#12734
60151fb 
 + Fixed auto import line breaks
@EnricoMessall EnricoMessall mentioned this issue Mar 10, 2023
Merged
EnricoMessall added a commit to Arematics/primeng that referenced this issue Mar 10, 2023
@EnricoMessall
Issue primefaces#12734
6a49b94 
 + Runned prettier
EnricoMessall added a commit to Arematics/primeng that referenced this issue Mar 11, 2023
@EnricoMessall
Issue primefaces#12734
514e9f7 
 + Use of this.document instead direct document
@cetincakiroglu cetincakiroglu added Status: Pending Review Issue or pull request is being reviewed by Core Team Angular Universal Issue or pull request is related to Angular Universal Server Side Rendering and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 24, 2023
@cetincakiroglu cetincakiroglu self-assigned this Mar 24, 2023
@cetincakiroglu cetincakiroglu added this to the 15.2.2 milestone Mar 25, 2023
@cetincakiroglu cetincakiroglu removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Mar 25, 2023
EnricoMessall added a commit to Arematics/primeng that referenced this issue Mar 25, 2023
@EnricoMessall
Issue primefaces#12734
bb4ed58 
 + Fixed Prettier for Landing Page
cetincakiroglu added a commit that referenced this issue Mar 25, 2023
@cetincakiroglu
Merge pull request #12735 from Arematics/issue-12734
e81b529 
Fixes #12734 - Add Document Injection
@cetincakiroglu cetincakiroglu added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cetincakiroglu cetincakiroglu

Labels
Angular Universal Issue or pull request is related to Angular Universal Server Side Rendering Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
15.3.0
Development

Successfully merging a pull request may close this issue.

Fixes primefaces/primeng#12734 - Add Document Injection Arematics/primeng
2 participants
@EnricoMessall @cetincakiroglu