Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-password: attribute 'className' instead of 'class' used in content template #13003

Closed
Ursuss21 opened this issue May 5, 2023 · 1 comment · Fixed by #13031
Closed

p-password: attribute 'className' instead of 'class' used in content template #13003

Ursuss21 opened this issue May 5, 2023 · 1 comment · Fixed by #13031
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Ursuss21
Copy link

Ursuss21 commented May 5, 2023

Describe the bug

Hello. I've been working on customizing the p-password component in one of my projects. When I attempted to style out the p-password-info class, I haven't received any results. I thought that maybe there was a specificity issue, but nothing helped, even using !important temporarily. I've looked into the codebase, and found out the line I wanted to check:

<div className="p-password-info">{{ infoText }}</div>

As you can see, class name 'p-password-info' is applied to the attribute 'className', which, I believe, doesn't work and doesn't apply styles. I guess the solution would be to just replace it with:

<div class="p-password-info">{{ infoText }}</div>

Should I make a PR regarding this issue? I know it's small and it's not something super important, but it could be useful to have the ability to customize the text for someone.

Environment

Ubuntu 20.04

Reproducer

No response

Angular version

15.2.6

PrimeNG version

15.2.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16.20.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@Ursuss21 Ursuss21 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 5, 2023
volvachev added a commit to volvachev/primeng that referenced this issue May 11, 2023
@volvachev
Copy link
Contributor

Hello, I opened pr. at the moment you can style through the attribute

@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 21, 2023
@mertsincan mertsincan added this to the 16.2.1 milestone Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants