Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete dead animations code #13116

Closed
czogran opened this issue May 30, 2023 · 0 comments · Fixed by #13117
Closed

Autocomplete dead animations code #13116

czogran opened this issue May 30, 2023 · 0 comments · Fixed by #13117
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@czogran
Copy link
Contributor

czogran commented May 30, 2023

Describe the bug

Autocomplete animation is never triggered

Autocomplete animation is done in p-overlay and the below code is never executed leading to confusion.

animations: [trigger('overlayAnimation', [transition(':enter', [style({ opacity: 0, transform: 'scaleY(0.8)' }), animate('{{showTransitionParams}}')]), transition(':leave', [animate('{{hideTransitionParams}}', style({ opacity: 0 }))])])],

Environment

master

Reproducer

No response

Angular version

15.2.4

PrimeNG version

15.2.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16.19.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

Removing dead code
@czogran czogran added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 30, 2023
@czogran czogran changed the title Component: Title Autocomplete dead animations code May 30, 2023
czogran added a commit to czogran/primeng that referenced this issue May 30, 2023
@czogran
Fixed primefaces#13116 Autocomplete dead animations code
55962b8
@czogran czogran mentioned this issue May 30, 2023
Merged
cetincakiroglu added a commit that referenced this issue Jun 16, 2023
@cetincakiroglu
Merge pull request #13117 from czogran/13116
1c95479 
Fixed #13116 Autocomplete dead animations code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed #13116 Autocomplete dead animations code czogran/primeng
1 participant
@czogran