TreeNode: data is no longer generic

[kyjus25]

Describe the bug

The data attribute of TreeNode is now type any, which breaks the previous implementation of passing in a generic <T> value for data.
https://github.com/primefaces/primeng/blob/master/src/app/components/api/treenode.ts

The TreeNode would now probably have to be defined as something like TreeNode & { data?: T }, which is not ideal.

Here is what it used to be:
https://github.com/primefaces/primeng/blob/14.2.3/src/app/components/api/treenode.ts

Environment

Angular 16
PrimeNG 16

Reproducer

No response

Angular version

16.0.0

PrimeNG version

16.0.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

TreeNode should accept a generic data type instead of any

[thetric]

Broken in commit d3b00fc.

I was quite surprised of this breaking change in the public API because virtually no breaking changes was documented

[olegkap]

There is similar breaking change in cascade select control where now you can only bind any[] and not specific type as before.
I will work on example case later today but just wanted to give heads up since it might be related

[psarno]

Confirmed, had to switch all of ours to the non-generic version to get it to compile.

[bhalperin]

👏

[ficifor]

The data attribute is still type any, the generic value is not being passed on.

[gerbermichi]

The bug still exists in version 16.0.2.

[bhalperin]

The bug still exists in version 16.0.2.

@gerbermichi does it fail in compile time? My experience is that compilation failed in v16.0.1 but passed successfully in v16.0.2.

[gerbermichi]

It doesn't compile.

https://github.com/primefaces/primeng/blob/master/src/app/components/api/treenode.ts

export interface TreeNode<T = any> {
    /**
     * Label of the node.
     */
    label?: string;
    /**
     * Data represented by the node.
     */
    data?: any;

data should be T not any.

[bhalperin]

It doesn't compile.

https://github.com/primefaces/primeng/blob/master/src/app/components/api/treenode.ts

export interface TreeNode<T = any> {
    /**
     * Label of the node.
     */
    label?: string;
    /**
     * Data represented by the node.
     */
    data?: any;

data should be T not any.

My app compiles and seems to behave as expected. But you are right, should be data?: T;

[tlinford]

Also can't compile after updating. could this be reopened?

[bhalperin]

👍