Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Component: esc button doesn't close the preview #13305

Closed
GeorgeHulpoi opened this issue Jul 8, 2023 · 1 comment · Fixed by #13309
Closed

Image Component: esc button doesn't close the preview #13305

GeorgeHulpoi opened this issue Jul 8, 2023 · 1 comment · Fixed by #13309
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA LTS-FIXED-14.2.11 LTS-PORTABLE
Milestone
16.1.0

Comments

@GeorgeHulpoi
Copy link

Describe the bug

Image Component should be closed when you press on ESC button. Even on https://primeng.org/image doesn't work.

Environment

Reproducer

https://primeng.org/image

Angular version

16.0.2

PrimeNG version

latest

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

unknown

Browser(s)

Edge, Chrome, to be confirmed on the rest

Steps to reproduce the behavior

Click on the preview and try to press ESC.

Expected behavior

It should close the Image preview
@GeorgeHulpoi GeorgeHulpoi added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 8, 2023
@GeorgeHulpoi GeorgeHulpoi changed the title Image Component: Image Component: esc button doesn't close the preview Jul 8, 2023
SoyDiego added a commit to SoyDiego/primeng that referenced this issue Jul 9, 2023
@SoyDiego
[primefaces#13305] - Fixed ESC button close preview on image Component
0facc2d
@SoyDiego SoyDiego mentioned this issue Jul 9, 2023
Merged
@SoyDiego
Copy link
Contributor

SoyDiego commented Jul 9, 2023 •
edited

Hi @GeorgeHulpoi, I have checked the Image Component and you are right.
I have create a PR #13309 fixing that part.
If the PrimeNG Team approve, it will be in the next release.

@cetincakiroglu cetincakiroglu added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 10, 2023
@cetincakiroglu cetincakiroglu modified the milestones: 16.Future, 16.0.3 Jul 10, 2023
cetincakiroglu added a commit that referenced this issue Jul 10, 2023
@cetincakiroglu
Merge pull request #13309 from SoyDiego/fix-ESC-Button-close-preview-…
b5c3829 
…image-component

[#13305] - Fixed ESC button close preview on image Component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA LTS-FIXED-14.2.11 LTS-PORTABLE
Projects
None yet
Milestone
16.1.0
Development

Successfully merging a pull request may close this issue.

[#13305] - Fixed ESC button close preview on image Component SoyDiego/primeng
4 participants
@GeorgeHulpoi @SoyDiego @gucal @cetincakiroglu