Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileUpload: allow file size units internationalization #13398

Closed
ajjp opened this issue Jul 29, 2023 · 2 comments
Closed

FileUpload: allow file size units internationalization #13398

ajjp opened this issue Jul 29, 2023 · 2 comments
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
16.4.0

Comments

@ajjp
Copy link

ajjp commented Jul 29, 2023 •
edited
Loading

Describe the feature you would like to see added

Define the formatSize units in the language I want.

Is your feature request related to a problem?

I need to display file size units in French language:

['o', 'ko', 'Mo', 'Go', 'To', 'Po', 'Eo', 'Zo', 'Yo']

Describe the solution you'd like

Have an Input parameter to define formatSize

Describe alternatives you have considered

No response

Additional context

No response

image
@ajjp ajjp added Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: New Feature Issue contains a new feature or new component request labels Jul 29, 2023
@SoyDiego SoyDiego mentioned this issue Jul 29, 2023
Closed
@SoyDiego
Copy link
Contributor

Hi @ajjp. I have created a PR here #13400 to add this new feature. Now we should wait for PrimeNG to review and approve it.

@gucal gucal added this to the 16.Future milestone Aug 28, 2023
@mertsincan mertsincan modified the milestones: 16.Future, 16.3.2 Sep 2, 2023
@mertsincan mertsincan removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 2, 2023
@mertsincan
Copy link
Member

Fixed in #13603

@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Type: New Feature Issue contains a new feature or new component request Status: Discussion Issue or pull request needs to be discussed by Core Team labels Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
16.4.0
Development

Successfully merging a pull request may close this issue.

Added customSizes to fileupload component SoyDiego/primeng
4 participants
@mertsincan @SoyDiego @gucal @ajjp