Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: TabView - Scrollable - Forward button problems #13422

Closed
GiacomoDM opened this issue Aug 2, 2023 · 1 comment
Closed

Component: TabView - Scrollable - Forward button problems #13422

GiacomoDM opened this issue Aug 2, 2023 · 1 comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@GiacomoDM
Copy link
Contributor

Describe the bug

When a TabView is set to scrollable="true", the forward button is always visible on start, even if the tabs cannot scroll because they don't take all the horizontal space.
image

Also, even when scrolling to the last element, the forward button doesn't always disappear due to a rounding error. To reproduce this second problem just use the example here: https://primeng.org/tabview#scrollable on monitor with different sizes.

Environment

Windows

Reproducer

https://stackblitz.com/edit/n1wgnj?file=src%2Fapp%2Fdemo%2Ftab-view-scrollable-demo.ts

Angular version

16.X

PrimeNG version

16.1.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16.20

Browser(s)

No response

Steps to reproduce the behavior

Problem 1:

  1. Open the provided stackblitz
  2. The forward button is visible

Problem 2:

  1. Go to https://primeng.org/tabview#scrollable
  2. Press forward until scrolled to the last element
  3. The button is visible (try with different monitor sizes/resolutions/zoom)

Expected behavior

At steps 2 and 3 respectively, the button should be hidden.
@GiacomoDM GiacomoDM added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 2, 2023
GiacomoDM added a commit to GiacomoDM/primeng that referenced this issue Aug 2, 2023
@GiacomoDM
Bugfix primefaces#13422 Hide buttons after view init + round scrollLeft
3c9ab67
@GiacomoDM GiacomoDM mentioned this issue Aug 2, 2023
Merged
GiacomoDM added a commit to GiacomoDM/primeng that referenced this issue Aug 7, 2023
@GiacomoDM
Revert "Bugfix primefaces#13422 Hide buttons after view init + round …
fd326bb 
…scrollLeft"

This reverts commit 3c9ab67.
@GiacomoDM
Copy link
Contributor Author

Fixed with #13478.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GiacomoDM