Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar: Badge property not working #13523

Closed
gabboman opened this issue Aug 21, 2023 · 5 comments
Closed

Sidebar: Badge property not working #13523

gabboman opened this issue Aug 21, 2023 · 5 comments
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@gabboman
Copy link

Describe the bug

The badge property on the sidebar menu gets rendered as regular text without anything else
imagen
imagen
This bug did not happend before the update to 16.2.0. it was ok in 16.0.0

Environment

primeng with primeflex. This bug started happening after the update to 16.2.0

Reproducer

No response

Angular version

16.2.0

PrimeNG version

16.0.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.12.0

Browser(s)

No response

Steps to reproduce the behavior

the badge should be displayed as a small number in a colorful circle

Expected behavior

No response

@gabboman gabboman added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 21, 2023
@SoyDiego
Copy link
Contributor

Describe the bug

The badge property on the sidebar menu gets rendered as regular text without anything else imagen imagen This bug did not happend before the update to 16.2.0. it was ok in 16.0.0

Environment

primeng with primeflex. This bug started happening after the update to 16.2.0

Reproducer

No response

Angular version

16.2.0

PrimeNG version

16.0.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.12.0

Browser(s)

No response

Steps to reproduce the behavior

the badge should be displayed as a small number in a colorful circle

Expected behavior

No response

Please, share a stackblitz.

Thanks

@gabboman
Copy link
Author

@SoyDiego I am afraid that the stackblitz fails when using this.
https://stackblitz.com/edit/github-yrp44t?file=src%2Fapp%2Fcomponents%2Fnavigation-menu%2Fnavigation-menu.module.ts,src%2Fapp%2Fcomponents%2Fnavigation-menu%2Fnavigation-menu.component.html,src%2Fapp%2Fapp.component.ts,src%2Fapp%2Fapp.module.ts,src%2Fapp%2Fcomponents%2Fnavigation-menu%2Fnavigation-menu.component.scss

Here is my update:
Its not the sidebar component, is the panelMenu component.
I also can confirm that the issue happens in 16.1.0 but not in 16.0.2

@SoyDiego
Copy link
Contributor

@SoyDiego I am afraid that the stackblitz fails when using this. https://stackblitz.com/edit/github-yrp44t?file=src%2Fapp%2Fcomponents%2Fnavigation-menu%2Fnavigation-menu.module.ts,src%2Fapp%2Fcomponents%2Fnavigation-menu%2Fnavigation-menu.component.html,src%2Fapp%2Fapp.component.ts,src%2Fapp%2Fapp.module.ts,src%2Fapp%2Fcomponents%2Fnavigation-menu%2Fnavigation-menu.component.scss

Here is my update: Its not the sidebar component, is the panelMenu component. I also can confirm that the issue happens in 16.1.0 but not in 16.0.2

Yes, it's failing :(
image

@gabboman
Copy link
Author

@SoyDiego I am afraid that the stackblitz fails when using this. https://stackblitz.com/edit/github-yrp44t?file=src%2Fapp%2Fcomponents%2Fnavigation-menu%2Fnavigation-menu.module.ts,src%2Fapp%2Fcomponents%2Fnavigation-menu%2Fnavigation-menu.component.html,src%2Fapp%2Fapp.component.ts,src%2Fapp%2Fapp.module.ts,src%2Fapp%2Fcomponents%2Fnavigation-menu%2Fnavigation-menu.component.scss
Here is my update: Its not the sidebar component, is the panelMenu component. I also can confirm that the issue happens in 16.1.0 but not in 16.0.2

Yes, it's failing :( image

yep, well seems like next release will fix it. Will stay tuned for the 16.2.1 or whatever is the next one :D

mehrabisajad added a commit to mehrabisajad/primeng that referenced this issue Aug 22, 2023
…omponents of Tieredmenu and ContextMenu and so on.
@mehrabisajad
Copy link
Contributor

@SoyDiego I am afraid that the stackblitz fails when using this. https://stackblitz.com/edit/github-yrp44t?file=src%2Fapp%2Fcomponents%2Fnavigation-menu%2Fnavigation-menu.module.ts,src%2Fapp%2Fcomponents%2Fnavigation-menu%2Fnavigation-menu.component.html,src%2Fapp%2Fapp.component.ts,src%2Fapp%2Fapp.module.ts,src%2Fapp%2Fcomponents%2Fnavigation-menu%2Fnavigation-menu.component.scss

Here is my update: Its not the sidebar component, is the panelMenu component. I also can confirm that the issue happens in 16.1.0 but not in 16.0.2

Update the dependencies to fix the panelMenu component error.
"@angular-devkit/build-angular": "16.2.0",
"@angular/cli": "16.2.0",
"@angular/compiler-cli": "16.2.1",
"@types/node": "20.5.2",
"typescript": "5.1.6"

@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 26, 2023
@mertsincan mertsincan added this to the 16.2.1 milestone Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

4 participants