Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fileUpload: choose button is disabled after upload when you chose more files than the file limit #13566

Closed
ajjp opened this issue Aug 29, 2023 · 3 comments
Labels
LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@ajjp
Copy link

ajjp commented Aug 29, 2023

Describe the bug

When you choose more files than the established limit, then remove some of the files to go bellow or up to the parameterized limit and then upload, the file choose button remains disabled after upload is complete and every time you add a new file the file limit message is shown.

Environment

Windows

Reproducer

No response

Angular version

16.1.3

PrimeNG version

16.0.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.1

Browser(s)

Chrome

Steps to reproduce the behavior

  1. Initialize the component giving a fileLimit number
  2. Drag and drop or click file choose and choose more files than the fileLimit
  3. Remove the files in excess
  4. Upload the files
  5. The choose button remains disabled after upload is complete
  6. Drag and drop a file to the drop area
  7. The file limit message is displayed

Expected behavior

  1. Choose button should always be enabled after uploading the files
  2. The file limit message shouldn't be displayed if the number of files wasn't exceeded
@ajjp ajjp added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 29, 2023
@ajjp
Copy link
Author

ajjp commented Aug 29, 2023

image

image

The uploadedFileCount property is not reset to zero after upload is complete and perhaps it's needed to add it to the clear() method

dylansyoung added a commit to dylansyoung/primeng that referenced this issue Aug 29, 2023
dylansyoung added a commit to dylansyoung/primeng that referenced this issue Aug 29, 2023
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 29, 2023
@mertsincan mertsincan added this to the 16.2.1 milestone Aug 29, 2023
@mertsincan
Copy link
Member

Fixed in #13567

@dilaraerdemEtiya
Copy link

dilaraerdemEtiya commented Feb 8, 2024

@mertsincan Hi, this bug is still valid for primeNG version: 14.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

4 participants