Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OverlayPanel: Calendar and table inside OverlayPanel, click inside dissmiss the overlaypanel #13605

Closed
penihel opened this issue Sep 1, 2023 · 5 comments · Fixed by #13809
Closed

OverlayPanel: Calendar and table inside OverlayPanel, click inside dissmiss the overlaypanel #13605

penihel opened this issue Sep 1, 2023 · 5 comments · Fixed by #13809
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
16.7.0

Comments

@penihel
Copy link

penihel commented Sep 1, 2023

Describe the bug

Look this sample

https://primeng.org/overlaypanel#datatable

Try click to order the column, sometimes at 1st, sometimes at 2nd or 3rd click, the painel closes unexpectedly.

I'm also trying to place an inline "Calendar" inside an OverlayPanel, but when I click to browse previous months the panel unexpectedly closes as well.

Environment

Angular 16.2
primeng 16.2

Reproducer

https://primeng.org/overlaypanel#datatable

Angular version

16.2.0

PrimeNG version

16.2.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18

Browser(s)

Chrome

Steps to reproduce the behavior

https://primeng.org/overlaypanel#datatable

Expected behavior

the panel should stay open, only close when selecting the programmed action, or clicking outside the panel
@penihel penihel added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 1, 2023
@penihel penihel mentioned this issue Sep 1, 2023
Closed
@penihel penihel changed the title Component: Title OverlayPanel: Calendar and table inside OverlayPanel, click inside dissmiss the overlaypanel Sep 1, 2023
@penihel
Copy link
Author

penihel commented Sep 8, 2023

nothing about this?

1 similar comment
@penihel
Copy link
Author

penihel commented Sep 30, 2023

nothing about this?

@pete-mcwilliams
Copy link
Contributor

Here's a simple repro for the calendar was about to raise this issue also... click on buttons in header left, right, month and year dismisses the overlay
https://stackblitz.com/edit/xzstuc?file=src%2Fapp%2Fdemo%2Foverlay-panel-basic-demo.html

@gamerish96 gamerish96 mentioned this issue Oct 5, 2023
Merged
anlampe added a commit to anlampe/primeng that referenced this issue Oct 5, 2023
@anlampe
OverlayPanel: Fix regression primefaces#13605 & primefaces#13601 dete…
c8d13ea 
…ct click on scrollbar, prevent hiding when selecting dropdown options
anlampe added a commit to anlampe/primeng that referenced this issue Oct 5, 2023
@anlampe
OverlayPanel: Fix regression primefaces#13605 & primefaces#13601 dete…
df9e56d 
…ct click on scrollbar, prevent hiding e.g. when selecting dropdown options
@anlampe anlampe mentioned this issue Oct 5, 2023
Merged
@penihel
Copy link
Author

penihel commented Oct 30, 2023

@cagataycivici can you help here?

@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 1, 2023
@cetincakiroglu cetincakiroglu added this to the 16.7.0 milestone Nov 1, 2023
@cetincakiroglu
Copy link
Contributor

Fixed in #13809

anlampe added a commit to anlampe/primeng that referenced this issue Nov 2, 2023
@anlampe
OverlayPanel: Fix regression primefaces#13605 & primefaces#13601 dete…
039457b 
…ct click on scrollbar, prevent hiding e.g. when selecting dropdown options
anlampe added a commit to anlampe/primeng that referenced this issue Nov 2, 2023
@anlampe
OverlayPanel: Fix regression primefaces#13605 & primefaces#13601 dete…
d1a2d1d 
…ct click on scrollbar, prevent hiding e.g. when selecting dropdown options
@pete-mcwilliams pete-mcwilliams mentioned this issue Nov 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
16.7.0
Development

Successfully merging a pull request may close this issue.

Fixed OverlayPanel containing component gamerish96/primeng
3 participants
@penihel @cetincakiroglu @pete-mcwilliams