-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p-dialog: ExpressionChangedAfterItHasBeenCheckedError with attr.aria-labelledby #13636
Comments
I think I did a PR about that. Edit Thanks |
@SoyDiego I appreciate the help. It's in the dialog component, as per the stack trace:
And error:
I see the PR was merged. Did that go out with 16.3.1? If so then an issue persists here. I am unable to do a Stackblitz, see the bottom of my post, there is a link there ... can't get it to work with 16. |
Yes, was merged. It's very weird. |
Now I saw the problem. Thanks for report the issue |
Hi @psarno I tried to replicate your problem but I cannot see errors and anything. My codeTestingFor that maybe is good idea if you can replicate with Stackblitz. Thanks again |
@SoyDiego It seems to be the exact same issue as was occuring in #13497 just in a different component. It may be difficult to reproduce, I am not sure what the underlying cause is but it's probably no coincidence that we have the same error in two similar components on the same exact statement (with the Sometimes these things are not always immediately reproducible and we have to go off crash reports and put in defensive coding or fixes simply based off reports that include the call stack, such as this one does. Since this looks to be literally the same problem, with the same code, just in a different component, why not apply the same fix here to be safe? It was needed in one, why would it not be needed in both? And as I asked in the original post, is there any reason we don't have an updated Stackblitz repro template that uses the latest PrimeNG 16? I can not get 16 to work on StackBlitz, I am unsure why it throws this error. |
@psarno I will create a new PR adding the same implementations because you are right, It's the same problem but I don't know why can't replicated. And I'm not decide this things and I don't know why Stackblitz is not working. |
The error is occuring in the
That is overly simplified but it shows the control that causes this error to occur. When we type a character into the |
@SoyDiego Understood that you're just a contributor, you are doing a great work with the PRs. I am also just leaving these notes here so the PrimeNG team can see the logic behind what is going on, if this is ever merged. @cagataycivici Is there any chance we can get an officially updated Stackblitz template for PrimeNG from your team to version 16? I don't know who to contact about that. The current one is on 14. I have tried to get it working with 16 but run into one particular error I haven't figured out. |
I tried with this example too and I couldn't see the problem. |
@psarno @cetincakiroglu hi guys, I see that this fix become on 16.4.2 release, how I can get before? |
Hi @psarno, You can't get before, we'll release it today! |
Describe the bug
I know some work is being done here on accessability, and I saw a related issue but not with the
p-dialog
component.We are on the latest PrimeNG version (16.3.1).
The exception is:
Call Stack:
Line in primeng-dialog.mjs triggering this:
Dialog defined as:
Also - Can we get an updated reproducer template that isn't on Angular 14 and PrimeNG 14?
I am unable to update the template in stackblitz to Angular 16/PrimeNG 16, no matter what I try I end up with:
Environment
Angular 16.2.2
PrimeNG 16.3.1
Reproducer
No response
Angular version
16.2.2
PrimeNG version
16.3.1
Build / Runtime
Angular CLI App
Language
TypeScript
Node version (for AoT issues node --version)
18.16.0
Browser(s)
No response
Steps to reproduce the behavior
Expected behavior
There is no ExpressionChangedAfterItHasBeenCheckedError
The text was updated successfully, but these errors were encountered: