-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DynamicDialog: ExpressionChangedAfterItHasBeenCheckedError for attr.aria-labelledby #13497
Comments
The same issue |
Same issue here too. |
The same issue |
I was checking the problem and try using changeDetectorRef, but I still have't been able to fix the error. |
Same issue here. @SoyDiego I've just seen this bug. I left this comment on the MR that (I believe) introduced the issue: #13477 (comment) Is there a need to update the template as per the function change? From the top of my head, the solution would be to bind the template to a property and set it when really needed. Thanks for the efforts crew. |
Hi guys and thanks for your help @fbobbio. |
Same issue here. In my case, the error continuously fires when trying to open the dialog and hence the dialog never opens and the application hangs |
My work around, example code that I am working on.
|
Thank you - this has worked for me |
@SoyDiego sent a PR that resolved the issue. |
@gucal and @SoyDiego thanks! Sent this PR #13511 First time contributing here so I am not sure about the workflow to get a new version/tag published :) Would be good to have this fix available. Thanks again ✌️ |
in which release will this bug be fixed? |
Refactor dynamic dialog: Errors when is opened #13497
The current solution has been replaced with a better solution. #13538 |
Just in case) The same error for 16.2.0. Looking forward to 16.2.1) |
Yes, will be fixed in next release and the currently 16.2.0 has the problem |
Describe the bug
ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value for 'attr.aria-labelledby': 'pn_id_157_header'. Current value: 'pn_id_159_header'. Expression location: DynamicDialogComponent component.
aria-labeledby is assign for div with class 'p-dynamic-dialog'
Environment
Basic as possible, Angular + PrimeNG only
Reproducer
https://stackblitz.com/edit/pfqjsp?file=package.json
Angular version
16.2.0
PrimeNG version
16.2.0
Build / Runtime
Angular CLI App
Language
TypeScript
Node version (for AoT issues node --version)
18.16.0
Browser(s)
Firefox 116.0
Steps to reproduce the behavior
Expected behavior
No response
The text was updated successfully, but these errors were encountered: