-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ColumnFilter in row mode and type date not trigger change when value change #13672
Comments
@PierreB40 , but i can not see any date property in this object and you did not define any date property in globalfilter value. |
This is not related to the data, but to the behavior of the filter. |
Thanks @PierreB40 , now i got it. |
…rigger change when value change
@PierreB40 can you check my PR, this issue solved on this PR |
Your solution corrects the action of selecting a date in the calendar |
@PierreB40 I understand your point but it's not free text box it's a calendar, when you type any date in input box if it match with colander format then automatically it filter, event you don't need to press enter. you can check video to understand the behavior more details. https://www.awesomescreenshot.com/video/20777390?key=48435726b29035f62f5d75e729b81c38 |
@ashikjs I know what you mean, the problem is that the calendar doesn't wait for a good format to trigger ngModelChange, so in lazy loading every keyboard entry triggers onLazyLoad |
@PierreB40 here ngModelChange only tiger when calendar value change not user on type. If it was firing event on every key press then I will not provided this solution. |
…rigger change when value change
…rigger change when value change
…rigger change when value change
…er-date-type-not-work fix: #13672 || ColumnFilter in row mode and type date not trigger
Describe the bug
Using p-columnFilter in row mode and date type
Select a value in the calendar
Environment
x
Reproducer
https://codesandbox.io/s/primeng-table-filter-row-date-59jwcy
Angular version
16.2.1
PrimeNG version
16.3.1
Build / Runtime
Angular CLI App
Language
TypeScript
Node version (for AoT issues node --version)
18.17.1
Browser(s)
No response
Steps to reproduce the behavior
In the reproduction link, the filter in the first column (date) is a date filter.
Selecting a new filter value does not trigger a change, nor does pressing enter. A matchMode must be chosen to trigger a change.
Expected behavior
A change when the value is modified or when enter is pressed, as with other filters in row mode.
The text was updated successfully, but these errors were encountered: